D27620: [krun] Share implementation of runService and runApplication

2020-03-02 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:a35cbeabc162: [krun] Share implementation of runService 
and runApplication (authored by davidedmundson).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27620?vs=76274=76756

REVISION DETAIL
  https://phabricator.kde.org/D27620

AFFECTED FILES
  src/widgets/krun.cpp

To: davidedmundson, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27620: [krun] Share implementation of runService and runApplication

2020-02-24 Thread Aleix Pol Gonzalez 
apol added a comment.


  Don't we need KDesktopFile::isAuthorizedDesktopFile now?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27620

To: davidedmundson, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27620: [krun] Share implementation of runService and runApplication

2020-02-24 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> krun.cpp:716
> +if (!flags.testFlag(DeleteTemporaryFiles)) {
> +// Remember we opened those urls, for the "recent documents" menu in 
> kicker
> +for (const QUrl  : urls) {

while at it, let's stop calling it kicker?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27620

To: davidedmundson, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27620: [krun] Share implementation of runService and runApplication

2020-02-24 Thread David Edmundson 
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Since they now effectively do the same thing.
  This patch also saves recent documents when runApplication is called

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27620

AFFECTED FILES
  src/widgets/krun.cpp

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns