D27628: Buttons: allow to scale up icons

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:0b89e7f3f089: Buttons: allow to scale up icons (authored 
by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27628?vs=76310=76769

REVISION DETAIL
  https://phabricator.kde.org/D27628

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml
  tests/components/toolbutton3.qml

To: mart, #plasma, broulik
Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27628: Buttons: allow to scale up icons

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Lovely.
  
  - Media controller is fine now
  - Pin on systray popup is fine
  - buttons in NM applet are fine

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/anothersizehint

REVISION DETAIL
  https://phabricator.kde.org/D27628

To: mart, #plasma, broulik
Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27628: Buttons: allow to scale up icons

[Nathaniel Graham]

ngraham added a comment.


  +1 visually and behaviorally; fixes the issues described in D27260 
 and D27449 
.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27628

To: mart, #plasma
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27628: Buttons: allow to scale up icons

[Marco Martin]

mart edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27628

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27628: Buttons: allow to scale up icons

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  always scale icons unless a size is specified in the api.
  this makes icon sizing more in line with plasma components 2

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/anothersizehint

REVISION DETAIL
  https://phabricator.kde.org/D27628

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml
  tests/components/toolbutton3.qml

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns