D27704: Drop FindAccountsFileDir.cmake

2020-04-14 Thread Nicolas Fella 
nicolasfella abandoned this revision.

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27704

To: nicolasfella, #frameworks, bshah, leinir, lbeltrame
Cc: lbeltrame

D27704: Drop FindAccountsFileDir.cmake

2020-03-10 Thread Luca Beltrame 
lbeltrame requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27704

To: nicolasfella, #frameworks, bshah, leinir, lbeltrame
Cc: lbeltrame

D27704: Drop FindAccountsFileDir.cmake

2020-03-10 Thread Luca Beltrame 
lbeltrame reopened this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.


  "No one using it" is not correct. Or at least, `ACCOUNTS_SERVICES_DIR`, set 
in that file, is used by kaccounts-providers. I'll revert the change (breaks 
building other projects), but probably it can be fixed if that variable is not 
used anywhere.

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27704

To: nicolasfella, #frameworks, bshah, leinir
Cc: lbeltrame

D27704: Drop FindAccountsFileDir.cmake

2020-03-09 Thread Nicolas Fella 
This revision was automatically updated to reflect the committed changes.
Closed by commit R155:17ff746ba128: Drop FindAccountsFileDir.cmake (authored by 
nicolasfella).

REPOSITORY
  R155 KAccounts Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27704?vs=76561=77278

REVISION DETAIL
  https://phabricator.kde.org/D27704

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/cmake/CMakeLists.txt
  src/lib/cmake/FindAccountsFileDir.cmake

To: nicolasfella, #frameworks, bshah, leinir

D27704: Drop FindAccountsFileDir.cmake

2020-03-09 Thread Dan Leinir Turthra Jensen 
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  Removing unused stuff is always nice, well spotted :)

REPOSITORY
  R155 KAccounts Integration

BRANCH
  cma

REVISION DETAIL
  https://phabricator.kde.org/D27704

To: nicolasfella, #frameworks, bshah, leinir

D27704: Drop FindAccountsFileDir.cmake

2020-02-27 Thread Nicolas Fella 
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, bshah, leinir.
nicolasfella requested review of this revision.

REVISION SUMMARY
  no one is using it

REPOSITORY
  R155 KAccounts Integration

BRANCH
  cma

REVISION DETAIL
  https://phabricator.kde.org/D27704

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/cmake/CMakeLists.txt
  src/lib/cmake/FindAccountsFileDir.cmake

To: nicolasfella, #frameworks, bshah, leinir