D27708: Cleanup accounts kded module
This revision was automatically updated to reflect the committed changes. Closed by commit R155:4d36ced449f2: Cleanup accounts kded module (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27708?vs=77182=77277#toc REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27708?vs=77182=77277 REVISION DETAIL https://phabricator.kde.org/D27708 AFFECTED FILES src/CMakeLists.txt src/daemon/CMakeLists.txt src/daemon/daemon.cpp src/daemon/daemon.h src/daemon/kded_accounts.json src/daemon/kio-webdav/CMakeLists.txt src/daemon/kio-webdav/createkioservice.cpp src/daemon/kio-webdav/createkioservice.h src/daemon/kio-webdav/createnetattachjob.cpp src/daemon/kio-webdav/createnetattachjob.h src/daemon/kio-webdav/kioservices.cpp src/daemon/kio-webdav/kioservices.h src/daemon/kio-webdav/removekioservice.cpp src/daemon/kio-webdav/removekioservice.h src/daemon/kio-webdav/removenetattachjob.cpp src/daemon/kio-webdav/removenetattachjob.h src/daemon/kio-webdav/tests/CMakeLists.txt src/daemon/kio-webdav/tests/testnetattachjobs.cpp src/kded/CMakeLists.txt src/kded/kded_accounts.cpp src/kded/kded_accounts.h src/kded/kded_accounts.json src/kded/kio-webdav/CMakeLists.txt src/kded/kio-webdav/createkioservice.cpp src/kded/kio-webdav/createkioservice.h src/kded/kio-webdav/createnetattachjob.cpp src/kded/kio-webdav/createnetattachjob.h src/kded/kio-webdav/kioservices.cpp src/kded/kio-webdav/kioservices.h src/kded/kio-webdav/removekioservice.cpp src/kded/kio-webdav/removekioservice.h src/kded/kio-webdav/removenetattachjob.cpp src/kded/kio-webdav/removenetattachjob.h src/kded/kio-webdav/tests/CMakeLists.txt src/kded/kio-webdav/tests/testnetattachjobs.cpp To: nicolasfella, #frameworks, bshah, leinir
D27708: Cleanup accounts kded module
bshah accepted this revision. REPOSITORY R155 KAccounts Integration BRANCH arcpatch-D27708 REVISION DETAIL https://phabricator.kde.org/D27708 To: nicolasfella, #frameworks, bshah, leinir
D27708: Cleanup accounts kded module
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. With the caveat that i'm not a big pile of brains about the plugin system, this looks like pretty sensible to me :) REPOSITORY R155 KAccounts Integration BRANCH arcpatch-D27708 REVISION DETAIL https://phabricator.kde.org/D27708 To: nicolasfella, #frameworks, bshah, leinir
D27708: Cleanup accounts kded module
nicolasfella updated this revision to Diff 77182. nicolasfella added a comment. rebase REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27708?vs=76570=77182 BRANCH arcpatch-D27708 REVISION DETAIL https://phabricator.kde.org/D27708 AFFECTED FILES src/CMakeLists.txt src/daemon/CMakeLists.txt src/daemon/daemon.cpp src/daemon/daemon.h src/daemon/kded_accounts.json src/daemon/kio-webdav/CMakeLists.txt src/daemon/kio-webdav/createkioservice.cpp src/daemon/kio-webdav/createkioservice.h src/daemon/kio-webdav/createnetattachjob.cpp src/daemon/kio-webdav/createnetattachjob.h src/daemon/kio-webdav/kioservices.cpp src/daemon/kio-webdav/kioservices.h src/daemon/kio-webdav/removekioservice.cpp src/daemon/kio-webdav/removekioservice.h src/daemon/kio-webdav/removenetattachjob.cpp src/daemon/kio-webdav/removenetattachjob.h src/daemon/kio-webdav/tests/CMakeLists.txt src/daemon/kio-webdav/tests/testnetattachjobs.cpp src/kded/CMakeLists.txt src/kded/kded_accounts.cpp src/kded/kded_accounts.h src/kded/kded_accounts.json src/kded/kio-webdav/CMakeLists.txt src/kded/kio-webdav/createkioservice.cpp src/kded/kio-webdav/createkioservice.h src/kded/kio-webdav/createnetattachjob.cpp src/kded/kio-webdav/createnetattachjob.h src/kded/kio-webdav/kioservices.cpp src/kded/kio-webdav/kioservices.h src/kded/kio-webdav/removekioservice.cpp src/kded/kio-webdav/removekioservice.h src/kded/kio-webdav/removenetattachjob.cpp src/kded/kio-webdav/removenetattachjob.h src/kded/kio-webdav/tests/CMakeLists.txt src/kded/kio-webdav/tests/testnetattachjobs.cpp To: nicolasfella, #frameworks, bshah, leinir
D27708: Cleanup accounts kded module
nicolasfella created this revision. nicolasfella added reviewers: Frameworks, bshah, leinir. nicolasfella requested review of this revision. REVISION SUMMARY Rename to emphasize it's a kded module plus some random cleanup TEST PLAN builds, kded5 starts REPOSITORY R155 KAccounts Integration BRANCH kded REVISION DETAIL https://phabricator.kde.org/D27708 AFFECTED FILES src/CMakeLists.txt src/daemon/CMakeLists.txt src/daemon/daemon.cpp src/daemon/daemon.h src/daemon/kded_accounts.json src/daemon/kio-webdav/CMakeLists.txt src/daemon/kio-webdav/createkioservice.cpp src/daemon/kio-webdav/createkioservice.h src/daemon/kio-webdav/createnetattachjob.cpp src/daemon/kio-webdav/createnetattachjob.h src/daemon/kio-webdav/kioservices.cpp src/daemon/kio-webdav/kioservices.h src/daemon/kio-webdav/removekioservice.cpp src/daemon/kio-webdav/removekioservice.h src/daemon/kio-webdav/removenetattachjob.cpp src/daemon/kio-webdav/removenetattachjob.h src/daemon/kio-webdav/tests/CMakeLists.txt src/daemon/kio-webdav/tests/testnetattachjobs.cpp src/kded/CMakeLists.txt src/kded/kded_accounts.cpp src/kded/kded_accounts.h src/kded/kded_accounts.json src/kded/kio-webdav/CMakeLists.txt src/kded/kio-webdav/createkioservice.cpp src/kded/kio-webdav/createkioservice.h src/kded/kio-webdav/createnetattachjob.cpp src/kded/kio-webdav/createnetattachjob.h src/kded/kio-webdav/kioservices.cpp src/kded/kio-webdav/kioservices.h src/kded/kio-webdav/removekioservice.cpp src/kded/kio-webdav/removekioservice.h src/kded/kio-webdav/removenetattachjob.cpp src/kded/kio-webdav/removenetattachjob.h src/kded/kio-webdav/tests/CMakeLists.txt src/kded/kio-webdav/tests/testnetattachjobs.cpp To: nicolasfella, #frameworks, bshah, leinir