D27794: Fix symlink problem because of using relative path instead of full path

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.


  Yes, the generation of relative symlinks is intentional and necessary.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27794

To: usta, ngraham, kossebau, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27794: Fix symlink problem because of using relative path instead of full path

[Noah Davis]

ndavis added a comment.


  Example: F8146162: Screenshot_20200302_233811.PNG 

  
  I renamed the original breeze-icons repo to breeze-icons2 and the symlinks 
broke because they were pointing to the source folder instead of the 
installation folder.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27794

To: usta, ngraham, kossebau, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27794: Fix symlink problem because of using relative path instead of full path

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Relative links are actually necessary. Otherwise, they won't work when the 
source repository isn't present.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27794

To: usta, ngraham, kossebau, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27794: Fix symlink problem because of using relative path instead of full path

[Ömer Fadıl Usta]

usta created this revision.
usta added reviewers: ngraham, kossebau, ndavis.
usta added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
usta requested review of this revision.

REVISION SUMMARY
  generate script was trying to read the source of symlinked files base but it 
was used as a relative path which causes problems for broken new symlinks.
  This fix is getting the full path of symlink so newly created files use 
correct path instead of a broken symlink also this fixes autotests (obvious 
because that problem will be solved :) )

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27794

AFFECTED FILES
  generate-24px-versions.sh

To: usta, ngraham, kossebau, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns