D27802: smb: fix ipv6 support

2020-03-06 Thread Harald Sitter 
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:bb83a071e0da: smb: fix ipv6 support (authored by sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27802?vs=76915=77120

REVISION DETAIL
  https://phabricator.kde.org/D27802

AFFECTED FILES
  smb/autotests/smburltest.cpp
  smb/smburl.cpp

To: sitter, ngraham
Cc: cfeck, thiago, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D27802: smb: fix ipv6 support

2020-03-05 Thread Harald Sitter 
sitter added a comment.


  Ah sorry for the unnecessary wait. I wasn't planning on 19.12. Thanks for 
asking though :)

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-smburl-static-autotest-ipv6

REVISION DETAIL
  https://phabricator.kde.org/D27802

To: sitter, ngraham
Cc: cfeck, thiago, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D27802: smb: fix ipv6 support

2020-03-05 Thread Christoph Feck 
cfeck added a comment.


  Well, cannot delay the release any longer.

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-smburl-static-autotest-ipv6

REVISION DETAIL
  https://phabricator.kde.org/D27802

To: sitter, ngraham
Cc: cfeck, thiago, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D27802: smb: fix ipv6 support

2020-03-04 Thread Christoph Feck 
cfeck added a comment.


  Should this be in 19.12 branch? I am doing a respin of kio-extras anyway.

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-smburl-static-autotest-ipv6

REVISION DETAIL
  https://phabricator.kde.org/D27802

To: sitter, ngraham
Cc: cfeck, thiago, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D27802: smb: fix ipv6 support

2020-03-04 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-smburl-static-autotest-ipv6

REVISION DETAIL
  https://phabricator.kde.org/D27802

To: sitter, ngraham
Cc: thiago, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27802: smb: fix ipv6 support

2020-03-04 Thread Thiago Macieira 
thiago added a comment.


  looks good to me.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27802

To: sitter, ngraham
Cc: thiago, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27802: smb: fix ipv6 support

2020-03-04 Thread Harald Sitter 
sitter updated this revision to Diff 76915.
sitter added a comment.


  guard against ending in dash
  
  also move to front() and back() for ease of reading

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27802?vs=76838=76915

BRANCH
  smb-smburl-static-autotest-ipv6

REVISION DETAIL
  https://phabricator.kde.org/D27802

AFFECTED FILES
  smb/autotests/smburltest.cpp
  smb/smburl.cpp

To: sitter, ngraham
Cc: thiago, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27802: smb: fix ipv6 support

2020-03-03 Thread Thiago Macieira 
thiago added a comment.


  STD3 also forbids domain labels ending in dash, so can you add a test for 
`smb://[fe80::]/` too? You'll need to adjust your code

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27802

To: sitter, ngraham
Cc: thiago, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27802: smb: fix ipv6 support

2020-03-03 Thread Harald Sitter 
sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  libsmbc doesn't presently support smb://[ABCD::DCBA]/ uris because it
  has very opinionated colon parsing. as a workaround we convert hosts
  that are ipv6 addresses to their windows ipv6 literal representation.
  that is basically s/:/-/g and s/%/s/g and appending .ipv6-literal.net.
  
  BUG: 417682
  FIXED-IN: 20.04

TEST PLAN
  builds, test passes, `'smb://[::1]/foo'` works as expected

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-smburl-static-autotest-ipv6

REVISION DETAIL
  https://phabricator.kde.org/D27802

AFFECTED FILES
  smb/autotests/smburltest.cpp
  smb/smburl.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov