D27950: Assign an icon to action submenus

2020-03-21 Thread Aleix Pol Gonzalez 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3f69e6401e44: Assign an icon to action submenus (authored 
by apol).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27950?vs=77295=78164

REVISION DETAIL
  https://phabricator.kde.org/D27950

AFFECTED FILES
  src/widgets/kfileitemactions.cpp

To: apol, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27950: Assign an icon to action submenus

2020-03-21 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27950

To: apol, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27950: Assign an icon to action submenus

2020-03-09 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 77295.
apol added a comment.


  oops

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27950?vs=77294=77295

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27950

AFFECTED FILES
  src/widgets/kfileitemactions.cpp

To: apol, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27950: Assign an icon to action submenus

2020-03-09 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Currently, action submenus (X-KDE-Submenu) have no icons.
  This patch makes it inherit the icon of the first action.
  There will always be at least one action, since empty submenus are
  eliminated earlier in the function.
  If the icon of the first action is empty, it will gracefully revert to
  old behavior (not having an icon).
  
  Patch by Chloe Kudryavtsev 

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27950

AFFECTED FILES
  src/widgets/kfileitemactions.cpp

To: apol, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns