D28130: Introduce api for passive notifications

2020-03-19 Thread Marco Martin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:cebaeb4daf59: Introduce api for passive notifications 
(authored by mart).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28130?vs=77983=77987

REVISION DETAIL
  https://phabricator.kde.org/D28130

AFFECTED FILES
  src/quickaddons/configmodule.cpp
  src/quickaddons/configmodule.h

To: mart, broulik
Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28130: Introduce api for passive notifications

2020-03-19 Thread Kai Uwe Broulik 
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  phab/passivenot

REVISION DETAIL
  https://phabricator.kde.org/D28130

To: mart, broulik
Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28130: Introduce api for passive notifications

2020-03-19 Thread Marco Martin 
mart updated this revision to Diff 77983.
mart added a comment.


  - const QVariant &

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28130?vs=77982=77983

BRANCH
  phab/passivenot

REVISION DETAIL
  https://phabricator.kde.org/D28130

AFFECTED FILES
  src/quickaddons/configmodule.cpp
  src/quickaddons/configmodule.h

To: mart
Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28130: Introduce api for passive notifications

2020-03-19 Thread Marco Martin 
mart updated this revision to Diff 77982.
mart added a comment.


  - const QVariant &

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28130?vs=77940=77982

BRANCH
  phab/passivenot

REVISION DETAIL
  https://phabricator.kde.org/D28130

AFFECTED FILES
  src/quickaddons/configmodule.cpp
  src/quickaddons/configmodule.h

To: mart
Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28130: Introduce api for passive notifications

2020-03-19 Thread Marco Martin 
mart added a comment.


  In D28130#630325 , @davidre wrote:
  
  > I wonder if it's for the use case wehere an InlineMessage doesn't work does 
it need to contain actions?
  
  
  doesn't really *need* it, but matches the existing api already existing in 
ApplicationWindow which is better to not have inconsitencies

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28130

To: mart
Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28130: Introduce api for passive notifications

2020-03-19 Thread Marco Martin 
mart added a comment.


  In D28130#630325 , @davidre wrote:
  
  > I wonder if it's for the use case wehere an InlineMessage doesn't work does 
it need to contain actions?
  
  
  doesn't really *need* it, but matches the existing api already existing in 
ApplicationWindow

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28130

To: mart
Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28130: Introduce api for passive notifications

2020-03-19 Thread David Redondo 
davidre added a comment.


  I wonder if it's for the use case wehere an InlineMessage doesn't work does 
it need to contain actions?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28130

To: mart
Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28130: Introduce api for passive notifications

2020-03-19 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> configmodule.h:507
> + */
> +void showPassiveNotification(const QString , QVariant timeout = 
> QVariant(), const QString  = QString(), const QJSValue  = 
> QJSValue());
>  Q_SIGNALS:

`const QVariant &`

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28130

To: mart
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28130: Introduce api for passive notifications

2020-03-18 Thread Marco Martin 
mart edited the summary of this revision.
mart edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28130

To: mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28130: Introduce api for passive notifications

2020-03-18 Thread Marco Martin 
mart created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  showPassiveNotification which mirrors
  ApplicationWindow.showPassiveNotification
  some kcms need to show a tiny non interrupting message for which neither
  a dialog nor an InlineMessage are adapt.

REPOSITORY
  R296 KDeclarative

BRANCH
  phab/passivenot

REVISION DETAIL
  https://phabricator.kde.org/D28130

AFFECTED FILES
  src/quickaddons/configmodule.cpp
  src/quickaddons/configmodule.h

To: mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns