D28312: Implement urls using hints

2020-05-18 Thread Nicolas Fella 
nicolasfella closed this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D28312

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28312: Implement urls using hints

2020-05-18 Thread Kai Uwe Broulik 
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  urlshint

REVISION DETAIL
  https://phabricator.kde.org/D28312

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28312: Implement urls using hints

2020-03-26 Thread Nicolas Fella 
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Set the hint directly in KNotification instead of the backend. Saves us a bit 
of code

TEST PLAN
  spectacle notifications still has an image

REPOSITORY
  R289 KNotifications

BRANCH
  urlshint

REVISION DETAIL
  https://phabricator.kde.org/D28312

AFFECTED FILES
  src/knotification.cpp
  src/notifybypopup.cpp

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns