D28460: Add KCModuleData as base class for plugin

2020-08-14 Thread Ahmad Samir 
ahmadsamir closed this revision.
ahmadsamir added a comment.


  Has been moved to 
https://invent.kde.org/frameworks/kcmutils/-/merge_requests/10

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28460

To: bport, #plasma, ervin
Cc: ahmadsamir, meven, broulik, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D28460: Add KCModuleData as base class for plugin

2020-08-14 Thread Ahmad Samir 
ahmadsamir added inline comments.

INLINE COMMENTS

> kcmoduleloader.cpp:164
> +
> +QVariantList args2(args.cbegin(), args.cend());
> +

Hello. This breaks the build for Qt 5.12 on the CI, (the min. required version 
in KF is still 5.12):
https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.12/155/console

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28460

To: bport, #plasma, ervin
Cc: ahmadsamir, meven, broulik, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D28460: Add KCModuleData as base class for plugin

2020-05-11 Thread Méven Car 
meven added inline comments.

INLINE COMMENTS

> kcmoduledata.h:35
> + *
> + * @since 5.70
> + */

@since 5.71

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28460

To: bport, #plasma, ervin
Cc: meven, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28460: Add KCModuleData as base class for plugin

2020-05-11 Thread Méven Car 
meven added inline comments.

INLINE COMMENTS

> kcmoduleloader.h:113
> + *
> + * @since 5.69
> + */

@since 5.71

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28460

To: bport, #plasma, ervin
Cc: meven, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28460: Add KCModuleData as base class for plugin

2020-04-21 Thread Benjamin Port 
bport retitled this revision from "Add KCModuleDada as base class for plugin" 
to "Add KCModuleData as base class for plugin".

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28460

To: bport, #plasma, ervin
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns