D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries
This revision was automatically updated to reflect the committed changes. Closed by commit R320:daec307b59e9: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28513?vs=79234=79457 REVISION DETAIL https://phabricator.kde.org/D28513 AFFECTED FILES smb/kio_smb_browse.cpp smb/wsdiscoverer.cpp To: sitter, ngraham, meven Cc: kossebau, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov
D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries
meven accepted this revision. meven added a comment. Seems good to me REPOSITORY R320 KIO Extras BRANCH smb-lazy-resolve REVISION DETAIL https://phabricator.kde.org/D28513 To: sitter, ngraham, meven Cc: kossebau, kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries
sitter updated this revision to Diff 79234. sitter added a comment. chop instead of convoluted remove REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28513?vs=79220=79234 BRANCH smb-lazy-resolve REVISION DETAIL https://phabricator.kde.org/D28513 AFFECTED FILES smb/kio_smb_browse.cpp smb/wsdiscoverer.cpp To: sitter, ngraham, meven Cc: kossebau, kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries
sitter added inline comments. INLINE COMMENTS > kossebau wrote in kio_smb_browse.cpp:239 > `QString::remove()` operates on the object itself, no need to assign back to > host. > > Besides, why not use `QString::chop(wsdSuffix.size())` ? Mh. Good point indeed, I'll move to chop. Thanks! REPOSITORY R320 KIO Extras BRANCH smb-lazy-resolve REVISION DETAIL https://phabricator.kde.org/D28513 To: sitter, ngraham, meven Cc: kossebau, kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries
kossebau added inline comments. INLINE COMMENTS > kio_smb_browse.cpp:239 > +QString host = m_current_url.host(); > +host = host.remove(host.size() - wsdSuffix.size(), wsdSuffix.size()); > +const QString dnssd(host + ".local"); `QString::remove()` operates on the object itself, no need to assign back to host. Besides, why not use `QString::chop(wsdSuffix.size())` ? REPOSITORY R320 KIO Extras BRANCH smb-lazy-resolve REVISION DETAIL https://phabricator.kde.org/D28513 To: sitter, ngraham, meven Cc: kossebau, kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries
sitter updated this revision to Diff 79220. sitter added a comment. reshuffle: instead of using .local directly use a fake .kio-disocvery-wsd suffix. look for that at listing time and redirect to name.local or name as appropriate this prevents dnssd results form incorrectly getting run through the query branch AND has a 100% fallback chance for the llmnr/netbios name if the dnssd name isn't resolvable for wsdiscoveries REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28513?vs=79132=79220 BRANCH smb-lazy-resolve REVISION DETAIL https://phabricator.kde.org/D28513 AFFECTED FILES smb/kio_smb_browse.cpp smb/wsdiscoverer.cpp To: sitter, ngraham, meven Cc: kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries
sitter retitled this revision from "smb: use prettyname.local for hostname of wsdiscoveries" to "smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries". sitter edited the summary of this revision. REPOSITORY R320 KIO Extras BRANCH smb-lazy-resolve REVISION DETAIL https://phabricator.kde.org/D28513 To: sitter, ngraham, meven Cc: kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
