D28553: Rename stylesheet color ButtonFocus -> Highlight

2020-04-05 Thread Noah Davis 
ndavis added a comment.


  @davidhurka Actually, I'm using Highlight. I still can't get ButtonFocus to 
work reliably and Highlight in icons now changes to white when a UI element 
gets highlighted, which is good. BTW, join the VDG chat if you haven't already.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28553

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28553: Rename stylesheet color ButtonFocus -> Highlight

2020-04-04 Thread David Hurka 
davidhurka abandoned this revision.
davidhurka added a comment.


  Ok, then I’ll let you do it.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28553

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28553: Rename stylesheet color ButtonFocus -> Highlight

2020-04-04 Thread Noah Davis 
ndavis added a comment.


  In D28553#641271 , @davidhurka 
wrote:
  
  > Cuttlefish (Ubuntu release)?
  >
  > So that means all icons should be changed from Highlight to ButtonFocus? 
That would also affect colorful icons. Some of them have Highlight and 
ButtonFocus in the stylesheet, fortunately with the same color.
  
  
  Don't worry about it. I'll do a pass once KF5.69 is released.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28553

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28553: Rename stylesheet color ButtonFocus -> Highlight

2020-04-04 Thread David Hurka 
davidhurka added a comment.


  Cuttlefish (Ubuntu release)?
  
  So that means all icons should be changed from Highlight to ButtonFocus? That 
would also affect colorful icons. Some of them have Highlight and ButtonFocus 
in the stylesheet, fortunately with the same color.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28553

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28553: Rename stylesheet color ButtonFocus -> Highlight

2020-04-04 Thread Noah Davis 
ndavis added a comment.


  Actually, I just tested the icons in Cuttlefish and apparently ButtonFocus 
works now, so it's preferred to Highlight. Sorry to give you the run around.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28553

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28553: Rename stylesheet color ButtonFocus -> Highlight

2020-04-04 Thread David Hurka 
davidhurka created this revision.
davidhurka added a reviewer: ndavis.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidhurka requested review of this revision.

REVISION SUMMARY
  This fixes the 3 icons with blue elements, which I recently modified. I used 
ButtonFocus, but it should be Highlight.

REPOSITORY
  R266 Breeze Icons

BRANCH
  rename-buttonfocus-highlight

REVISION DETAIL
  https://phabricator.kde.org/D28553

AFFECTED FILES
  icons-dark/actions/16/edit-text-frame-update.svg
  icons-dark/actions/16/filename-title-amarok.svg
  icons-dark/actions/16/insert-page-break.svg
  icons-dark/actions/22/edit-text-frame-update.svg
  icons-dark/actions/22/filename-title-amarok.svg
  icons-dark/actions/22/insert-page-break.svg
  icons/actions/16/edit-text-frame-update.svg
  icons/actions/16/filename-title-amarok.svg
  icons/actions/16/insert-page-break.svg
  icons/actions/22/edit-text-frame-update.svg
  icons/actions/22/filename-title-amarok.svg
  icons/actions/22/insert-page-break.svg

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns