D28624: Print a warning if runner is incompatible with KRunner

2020-04-29 Thread David Redondo
This revision was automatically updated to reflect the committed changes.
Closed by commit R308:e56def21a286: Print a warning if runner is incompatible 
with KRunner (authored by davidre).

REPOSITORY
  R308 KRunner

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28624?vs=79487=81486

REVISION DETAIL
  https://phabricator.kde.org/D28624

AFFECTED FILES
  src/runnermanager.cpp

To: davidre, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28624: Print a warning if runner is incompatible with KRunner

2020-04-28 Thread Kai Uwe Broulik
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Would be lovely if we could get this date parsing into `QVersionNumber` of 
`KFormat`, I'm seeing similar code also in kscreenlocker, kwin, libksysguard, 
...

REPOSITORY
  R308 KRunner

BRANCH
  warning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28624

To: davidre, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28624: Print a warning if runner is incompatible with KRunner

2020-04-06 Thread David Redondo
davidre created this revision.
davidre added a reviewer: broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Useful for finding out why runner isn't loaded even though it's enabled in
  settings. Can for example happen if a runner is installed by an application
  that's compiled against a newer KRunner version than Plasma.

TEST PLAN
  Try to load an incompatible runner plugin

REPOSITORY
  R308 KRunner

BRANCH
  warning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28624

AFFECTED FILES
  src/runnermanager.cpp

To: davidre, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns