D28831: Add note about porting loadMimeTypeIcon
This revision was automatically updated to reflect the committed changes. Closed by commit R302:fe3f59b27dcf: Add note about porting loadMimeTypeIcon (authored by nicolasfella). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28831?vs=80128=80186 REVISION DETAIL https://phabricator.kde.org/D28831 AFFECTED FILES src/kiconloader.h To: nicolasfella, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
D28831: Add note about porting loadMimeTypeIcon
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK, for the simple case (no overlays, no extraction of path). More complete documentation would include the args for QIcon::pixmap but OK, very often we just port to QIcon instead. REPOSITORY R302 KIconThemes BRANCH mime REVISION DETAIL https://phabricator.kde.org/D28831 To: nicolasfella, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
D28831: Add note about porting loadMimeTypeIcon
ngraham added a comment. +1 REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D28831 To: nicolasfella, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
D28831: Add note about porting loadMimeTypeIcon
nicolasfella created this revision. nicolasfella added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY We're phasing out loadMimeTypeIcon in favor of QIcon::fromTheme(). We can't oficially deprecate it yet since there are still unported users, but add a comment recommending alternative API. REPOSITORY R302 KIconThemes BRANCH mime REVISION DETAIL https://phabricator.kde.org/D28831 AFFECTED FILES src/kiconloader.h To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
