D28839: [PostingIterator] Make sure skipTo also works for first element

2020-04-15 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:dd1b7a6d02a5: [PostingIterator] Make sure skipTo also 
works for first element (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28839?vs=80154=80221

REVISION DETAIL
  https://phabricator.kde.org/D28839

AFFECTED FILES
  src/engine/postingiterator.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28839: [PostingIterator] Make sure skipTo also works for first element

2020-04-14 Thread Stefan Brüns 
bruns added a dependent revision: D28845: [OrpostingIterator] Allow skipping 
elements, implement skipTo.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28839

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28839: [PostingIterator] Make sure skipTo also works for first element

2020-04-14 Thread Stefan Brüns 
bruns added a dependent revision: D28844: [PhraseAndIterator] Replace recursive 
next() implementation.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28839

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28839: [PostingIterator] Make sure skipTo also works for first element

2020-04-14 Thread Stefan Brüns 
bruns added a dependent revision: D28843: [AndPostingIterator] Replace 
recursive next() implementation.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28839

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28839: [PostingIterator] Make sure skipTo also works for first element

2020-04-14 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28839

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28839: [PostingIterator] Make sure skipTo also works for first element

2020-04-14 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  In case next() has never been called on an iterator, docId() returns 0
  (it points before the first element). Only break the loop when next()
  returns 0.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28839

AFFECTED FILES
  src/engine/postingiterator.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams