D28844: [PhraseAndIterator] Replace recursive next() implementation

2020-04-15 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:c00cf2022763: [PhraseAndIterator] Replace recursive 
next() implementation (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28844?vs=80161=80234

REVISION DETAIL
  https://phabricator.kde.org/D28844

AFFECTED FILES
  src/engine/phraseanditerator.cpp
  src/engine/phraseanditerator.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28844: [PhraseAndIterator] Replace recursive next() implementation

2020-04-15 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28844

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28844: [PhraseAndIterator] Replace recursive next() implementation

2020-04-14 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  This changes the code for the PhraseAndIterator in the
  same way as done for the AndPostingIterator in D28843 
.
  
  The only difference is the additional
  checkIfPositionsMatch in the break criterion
  
  Depends on D28839 

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28844

AFFECTED FILES
  src/engine/phraseanditerator.cpp
  src/engine/phraseanditerator.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams