D28883: Add wrapper for wl_global_remove

2020-04-24 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:c557cdba3a73: Add wrapper for wl_global_remove (authored 
by davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28883?vs=80279=81103

REVISION DETAIL
  https://phabricator.kde.org/D28883

AFFECTED FILES
  autotests/client/test_wayland_blur.cpp
  src/server/global.cpp
  src/server/global.h

To: davidedmundson, #plasma, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28883: Add wrapper for wl_global_remove

2020-04-16 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28883

To: davidedmundson, #plasma, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28883: Add wrapper for wl_global_remove

2020-04-16 Thread David Edmundson
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Removes the Global from the registry, but does not delete the underlying
  wl_global
  
  Removal of a global is racey in wayland. 
  A client could be trying to bind at that moment.
  
  Typically globals are static for the lifespan of the compositor, however
  there are exceptions
  
  For those cases this call will can remove the global from the registry,
  but still keep the wl_global instance alive
  and handling bind requests.
  
  The compositor can then remove the Global wrapper (this object) deleting
  the wl_global after an arbitrary delay or
  keep it around for re-use for the duration of the compositor.

TEST PLAN
  Unit test
  Made blur global outlive BlurEffect - no longer disconnects plasma on config 
changes

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28883

AFFECTED FILES
  autotests/client/test_wayland_blur.cpp
  src/server/global.cpp
  src/server/global.h

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns