D28956: [QML Monitor] Show remaining time as soon as possible

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:60766d57999c: [QML Monitor] Show remaining time as soon 
as possible (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28956?vs=80489=81179

REVISION DETAIL
  https://phabricator.kde.org/D28956

AFFECTED FILES
  src/qml/experimental/monitor.cpp
  src/qml/experimental/monitor.h

To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28956: [QML Monitor] Show remaining time as soon as possible

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28956

To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28956: [QML Monitor] Show remaining time as soon as possible

[Stefan Brüns]

bruns added a comment.


  Ping!

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28956

To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28956: [QML Monitor] Show remaining time as soon as possible

[Stefan Brüns]

bruns added a comment.


  In D28956#651795 , @apol wrote:
  
  > You're using QDeadlineTimer weird. Why don't you use 
QDeadlineTimer::remainingTime() and ::setDeadline?
  
  
  Because both functions do a syscall.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28956

To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28956: [QML Monitor] Show remaining time as soon as possible

[Aleix Pol Gonzalez]

apol added a comment.


  You're using QDeadlineTimer weird. Why don't you use 
QDeadlineTimer::remainingTime() and ::setDeadline?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28956

To: bruns, #baloo, ngraham
Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28956: [QML Monitor] Show remaining time as soon as possible

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The update timer was started when the content indexing started. If a large
  file is encountered during the first second, the estimate could stay
  at "Estimating" for a considerable amount of time.
  
  If baloo_file has already indexed some files, an estimate is available
  immediately. Replace the QElapsedTimer with a QDeadlineTimer and
  initialize it to expired, so the first file triggers an estimate update.

TEST PLAN
  make sure baloo_has indexed enough files for an estimate (5 batches)
  touch a big file -> estimate is shown immediately

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28956

AFFECTED FILES
  src/qml/experimental/monitor.cpp
  src/qml/experimental/monitor.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams