D29021: Remove checks for notification service and fallback to KPassivePopup

2020-05-03 Thread Nicolas Fella 
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:a5f0b1f7c812: Remove checks for notification service and 
fallback to KPassivePopup (authored by nicolasfella).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29021?vs=80687=81823

REVISION DETAIL
  https://phabricator.kde.org/D29021

AFFECTED FILES
  src/notifybypopup.cpp
  src/notifybypopup.h

To: nicolasfella, #frameworks, #plasma, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29021: Remove checks for notification service and fallback to KPassivePopup

2020-05-01 Thread Nicolas Fella 
nicolasfella added a dependent revision: D29336: Remove galago from 
method/variable naming.

REPOSITORY
  R289 KNotifications

BRANCH
  nofallback2

REVISION DETAIL
  https://phabricator.kde.org/D29021

To: nicolasfella, #frameworks, #plasma, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29021: Remove checks for notification service and fallback to KPassivePopup

2020-04-29 Thread Kai Uwe Broulik 
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Verified that close signal works and that quitting plasma, sending a 
notification, then has the notification show up when plasma is started.
  Please wait until after Frameworks tagging before pushing this

REPOSITORY
  R289 KNotifications

BRANCH
  nofallback2

REVISION DETAIL
  https://phabricator.kde.org/D29021

To: nicolasfella, #frameworks, #plasma, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29021: Remove checks for notification service and fallback to KPassivePopup

2020-04-20 Thread Nicolas Fella 
nicolasfella edited the summary of this revision.
nicolasfella edited the test plan for this revision.
nicolasfella added reviewers: Frameworks, Plasma, broulik.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29021

To: nicolasfella, #frameworks, #plasma, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29021: Remove checks for notification service and fallback to KPassivePopup

2020-04-20 Thread Nicolas Fella 
nicolasfella created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  nofallback2

REVISION DETAIL
  https://phabricator.kde.org/D29021

AFFECTED FILES
  src/notifybypopup.cpp
  src/notifybypopup.h

To: nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns