D29098: Removed kde logo from sd and memory stick (/devices/64)

2020-04-22 Thread Noah Davis
ndavis added a comment.


  yes, I agree with @ngraham

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29098

To: saligari, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29098: Removed kde logo from sd and memory stick (/devices/64)

2020-04-22 Thread Nathaniel Graham
ngraham added a comment.


  Hmm, now there's a huge empty area on those icons. I think the Plasma logo 
was visually balancing out the composition a bit. Maybe the Plasma logo itself 
wasn't appropriate, but it looks like maybe *something* needs to live there in 
its place, or we need to re-arrange things a bit.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29098

To: saligari, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29098: Removed kde logo from sd and memory stick (/devices/64)

2020-04-22 Thread Chris Escargot
saligari edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29098

To: saligari, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29098: Removed kde logo from sd and memory stick (/devices/64)

2020-04-22 Thread Chris Escargot
saligari edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29098

To: saligari, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29098: Removed kde logo from sd and memory stick (/devices/64)

2020-04-22 Thread Chris Escargot
saligari added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29098

To: saligari, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29098: Removed kde logo from sd and memory stick (/devices/64)

2020-04-22 Thread Chris Escargot
saligari updated this revision to Diff 80898.
saligari added a comment.


  cleaned them and svgcleaned them

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29098?vs=80897=80898

BRANCH
  remove-kde-logo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29098

AFFECTED FILES
  icons-dark/devices/64/media-flash-memory-stick.svg
  icons-dark/devices/64/media-flash-sd-mmc.svg
  icons/devices/64/media-flash-memory-stick.svg
  icons/devices/64/media-flash-sd-mmc.svg

To: saligari
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29098: Removed kde logo from sd and memory stick (/devices/64)

2020-04-22 Thread Chris Escargot
saligari created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
saligari requested review of this revision.

REVISION SUMMARY
  I think it is not needed, especially since these icons are usually rather 
small

REPOSITORY
  R266 Breeze Icons

BRANCH
  remove-kde-logo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29098

AFFECTED FILES
  icons-dark/devices/64/media-flash-memory-stick.svg
  icons-dark/devices/64/media-flash-sd-mmc.svg
  icons/devices/64/media-flash-memory-stick.svg
  icons/devices/64/media-flash-sd-mmc.svg

To: saligari
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns