D29181: Use KFileMetaData for XAttr support instead of private reimplementation
This revision was automatically updated to reflect the committed changes. Closed by commit R293:774bd228b749: Use KFileMetaData for XAttr support instead of private reimplementation (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29181?vs=81185=81192 REVISION DETAIL https://phabricator.kde.org/D29181 AFFECTED FILES autotests/unit/file/CMakeLists.txt autotests/unit/file/filewatchtest.cpp autotests/unit/lib/baloo_xattr_p.h autotests/unit/lib/xattrdetector.cpp autotests/unit/lib/xattrdetector.h To: bruns, #baloo, ngraham, apol Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D29181: Use KFileMetaData for XAttr support instead of private reimplementation
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D29181 To: bruns, #baloo, ngraham, apol Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D29181: Use KFileMetaData for XAttr support instead of private reimplementation
bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY This removes a lot of duplicate code, and on top it actually works as it no longer hardcodes a number of locations (e.g. /tmp/ was always blacklisted). TEST PLAN ctest REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D29181 AFFECTED FILES autotests/unit/file/CMakeLists.txt autotests/unit/file/filewatchtest.cpp autotests/unit/lib/baloo_xattr_p.h autotests/unit/lib/xattrdetector.cpp autotests/unit/lib/xattrdetector.h To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams