D29323: Handle multi-line and rich-text notifications on Android

2020-05-02 Thread Volker Krause 
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:9bfd98a3d3da: Handle multi-line and rich-text 
notifications on Android (authored by vkrause).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29323?vs=81657=81721

REVISION DETAIL
  https://phabricator.kde.org/D29323

AFFECTED FILES
  src/android/org/kde/knotifications/NotifyByAndroid.java
  src/notifybyandroid.cpp

To: vkrause, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29323: Handle multi-line and rich-text notifications on Android

2020-05-01 Thread Nicolas Fella 
nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29323

To: vkrause, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29323: Handle multi-line and rich-text notifications on Android

2020-05-01 Thread Volker Krause 
vkrause added a comment.


  F8275264: Screenshot_20200501_124105.PNG 


REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29323

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29323: Handle multi-line and rich-text notifications on Android

2020-05-01 Thread Volker Krause 
vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  By default only a single line of the notification message is shown,
  for making longer messages readable we need to use the BigTextStyle
  to get expandable multi-line messages. In the single-line case this
  behaves as before.
  
  According to the documentation BigTextStyle also should enable rich
  text support, however that didn't seem to work here, so for now we
  strip out rich text to not show raw HTML tags.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29323

AFFECTED FILES
  src/android/org/kde/knotifications/NotifyByAndroid.java
  src/notifybyandroid.cpp

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns