D29336: Remove galago from method/variable naming

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:2012f675aed2: Remove galago from method/variable naming 
(authored by nicolasfella).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29336?vs=81680=81892

REVISION DETAIL
  https://phabricator.kde.org/D29336

AFFECTED FILES
  src/imageconverter.h
  src/notifybypopup.cpp
  src/notifybypopup.h
  src/notifybyportal.cpp

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29336: Remove galago from method/variable naming

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  nogalago

REVISION DETAIL
  https://phabricator.kde.org/D29336

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29336: Remove galago from method/variable naming

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  With D29021  the fallback notification 
system is gone and with it the need for differentating naming. Remove galago 
from the naming since it's outdated and might confuse readers unfamiliar with 
the code and its history. Also inline a now not needed function.

TEST PLAN
  Still get notifications, action invoked signal is correctly sent
  
  Depends on D29021 

REPOSITORY
  R289 KNotifications

BRANCH
  nogalago

REVISION DETAIL
  https://phabricator.kde.org/D29336

AFFECTED FILES
  src/imageconverter.h
  src/notifybypopup.cpp
  src/notifybypopup.h
  src/notifybyportal.cpp

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns