D29483: [knewfilemenu] Show inline warning when creating items with leading or trailing spaces

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29483

To: ngraham, #frameworks, #vdg, cfeck, cblack
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29483: [knewfilemenu] Show inline warning when creating items with leading or trailing spaces

[Carson Black]

cblack accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  
show-warnings-for-leading-and-trailing-spaces-when-creating-files-or-folders-and-wow-this-is-a-long-branch-name-at-this-point
 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29483

To: ngraham, #frameworks, #vdg, cfeck, cblack
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29483: [knewfilemenu] Show inline warning when creating items with leading or trailing spaces

[Nathaniel Graham]

ngraham added a comment.


  Ping.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29483

To: ngraham, #frameworks, #vdg, cfeck
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29483: [knewfilemenu] Show inline warning when creating items with leading or trailing spaces

[Nathaniel Graham]

ngraham updated this revision to Diff 82102.
ngraham added a comment.


  Spell "oddities" correctly

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29483?vs=82101&id=82102

BRANCH
  
show-warnings-for-leading-and-trailing-spaces-when-creating-files-or-folders-and-wow-this-is-a-long-branch-name-at-this-point
 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29483

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: ngraham, #frameworks, #vdg, cfeck
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29483: [knewfilemenu] Show inline warning when creating items with leading or trailing spaces

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Frameworks, VDG, cfeck.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This is a somewhat unusual thing for a user to do intentionally, so let's 
show a
  warning to make sure they're aware that they're doing it.
  
  BUG: 421075
  FIXED-IN: 5.71

TEST PLAN
  F8289470: Screenshot_20200506_081625.png 

  F8289471: Screenshot_20200506_081646.png 


REPOSITORY
  R241 KIO

BRANCH
  
show-warnings-for-leading-and-trailing-spaces-when-creating-files-or-folders-and-wow-this-is-a-long-branch-name-at-this-point
 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29483

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: ngraham, #frameworks, #vdg, cfeck
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns