D29735: Assign "Identifier" attribute to opening double quote instead of "Comment"

[Christoph Cullmann]

cullmann added a comment.


  Sure, thanks for the improvement!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29735

To: bewuethr, #framework_syntax_highlighting, dhaumann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
cblack, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, 
demsking, vkrause, sars

D29735: Assign "Identifier" attribute to opening double quote instead of "Comment"

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:f804af905ef3: Assign "Identifier" attribute to 
opening double quote instead of "Comment" (authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29735?vs=82808&id=82955

REVISION DETAIL
  https://phabricator.kde.org/D29735

AFFECTED FILES
  data/syntax/sql-postgresql.xml

To: bewuethr, #framework_syntax_highlighting, dhaumann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
cblack, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, 
demsking, vkrause, sars

D29735: Assign "Identifier" attribute to opening double quote instead of "Comment"

[Dominik Haumann]

dhaumann added a subscriber: cullmann.
dhaumann added a comment.


  @cullmann could you integrate this?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29735

To: bewuethr, #framework_syntax_highlighting, dhaumann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
cblack, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, 
demsking, vkrause, sars

D29735: Assign "Identifier" attribute to opening double quote instead of "Comment"

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Good catch :) please commit

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29735

To: bewuethr, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, 
cullmann, vkrause, sars

D29735: Assign "Identifier" attribute to opening double quote instead of "Comment"

[Benjamin Wuethrich]

bewuethr created this revision.
bewuethr added a reviewer: Framework: Syntax Highlighting.
bewuethr added a project: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
bewuethr requested review of this revision.

REVISION SUMMARY
  When the PostgreSQL syntax definition file was converted from using named 
attributes and contexts instead of numbers in this commit 
,
 the attribute for an opening double quote was incorrectly set to `"Comment"` 
instead of `"Identifier"`. This patch fixes that.
  
  BUG: 421445

TEST PLAN
  Incorrect opening double quote before fix:
  
  F8318517: Screenshot from 2020-05-14 00-00-30.png 

  
  Correct opening double quote after fix:
  
  F8318530: Screenshot from 2020-05-14 00-06-41.png 


REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29735

AFFECTED FILES
  data/syntax/sql-postgresql.xml

To: bewuethr, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, gennad, 
bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, 
vkrause, sars, dhaumann