D29800: Fix URL being passed as argument when launching a .desktop file

2020-05-17 Thread Ahmad Samir 
ahmadsamir added a comment.


  In D29800#672399 , @fvogt wrote:
  
  > Landed to invent - hopefully correctly: 
https://invent.kde.org/frameworks/kio/commit/84e9372f4fa2636f57dc456ac2fa2be271d6a7ec
  
  
  LGTM.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29800

To: fvogt, dfaure, marten
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29800: Fix URL being passed as argument when launching a .desktop file

2020-05-17 Thread Fabian Vogt 
fvogt marked an inline comment as done.
fvogt added a comment.


  Landed to invent - hopefully correctly: 
https://invent.kde.org/frameworks/kio/commit/84e9372f4fa2636f57dc456ac2fa2be271d6a7ec

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29800

To: fvogt, dfaure, marten
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29800: Fix URL being passed as argument when launching a .desktop file

2020-05-17 Thread Fabian Vogt 
fvogt closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29800

To: fvogt, dfaure, marten
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29800: Fix URL being passed as argument when launching a .desktop file

2020-05-16 Thread David Faure 
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thanks for the unittest and fix!
  
  Oversight on my side indeed.

INLINE COMMENTS

> openurljobtest.h:58
>  void takeOverAfterMimeTypeFound();
> +void runDeskopFileDirectly();
>  

Typo: Desktop

REPOSITORY
  R241 KIO

BRANCH
  execfi

REVISION DETAIL
  https://phabricator.kde.org/D29800

To: fvogt, dfaure, marten
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29800: Fix URL being passed as argument when launching a .desktop file

2020-05-16 Thread Fabian Vogt 
fvogt created this revision.
fvogt added reviewers: dfaure, marten.
Herald added a project: Frameworks.
fvogt requested review of this revision.

REVISION SUMMARY
  When a .desktop file is executed directly, it doesn't receive a parameter.
  BUG: 421364

TEST PLAN
  Test passes, applications open normally again.

REPOSITORY
  R241 KIO

BRANCH
  execfi

REVISION DETAIL
  https://phabricator.kde.org/D29800

AFFECTED FILES
  autotests/openurljobtest.cpp
  autotests/openurljobtest.h
  src/gui/openurljob.cpp

To: fvogt, dfaure, marten
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns