D29802: Require in-source build
ltoscano added a comment. I believe a few sentences in the the commit message contradicts each other. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre Cc: ltoscano, davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29802: Require in-source build
davidre requested changes to this revision. davidre added a comment. This revision now requires changes to proceed. I don't think we want to require in source builds REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29802: Require in-source build
ognarb accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29802: Require in-source build
ngraham created this revision. ngraham added reviewers: Frameworks, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY In addition to just being a good idea in general, the dynamic icon generation bit doesn't work properly with in-source builds. Let's formally require out-of-source builds. BUG: 421637 FIXED-IN: 5.71 TEST PLAN Try out of source build, get yelled at REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 AFFECTED FILES CMakeLists.txt To: ngraham, #frameworks, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
