D29811: t/simplify-sending-data-through-socket

[Jiří Paleček]

jpalecek abandoned this revision.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D29811

To: jpalecek, #frameworks
Cc: anthonyfieroni, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D29811: t/simplify-sending-data-through-socket

[David Edmundson]

davidedmundson added a comment.


  > that would probably mean recompiling most of KDE (Debian has packages for 
5.69 only). I will check out your change and see what remains.
  
  This isn't a universal rule that always applies, but generally speaking you 
can just roll back the the frameworks version in the CMakeLists.txt and build 
this one framework.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D29811

To: jpalecek, #frameworks
Cc: anthonyfieroni, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D29811: t/simplify-sending-data-through-socket

[Anthony Fieroni]

anthonyfieroni added a comment.


  > But I'm not quite ready for 5.70 yet, that would probably mean recompiling 
most of KDE
  
  That's not need. Check out master of KCrash, CMakeLists.txt lower kf5 version 
to match your, compile new patch and test. Then create patch without lower 
version changes.
  That's not cheat since kf5 guarantee backward compatibility.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D29811

To: jpalecek, #frameworks
Cc: anthonyfieroni, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D29811: t/simplify-sending-data-through-socket

[Jiří Paleček]

jpalecek added a comment.


  In D29811#672534 , @davidedmundson 
wrote:
  
  > Your base kcrash is quite out of date - I simplified this method 
considerably a month ago, which gets rid of the two paths.
  
  
  It is 5.69. Yeah, now I can see you got rid of it just after that. That is 
good! But I'm not quite ready for 5.70 yet, that would probably mean 
recompiling most of KDE (Debian has packages for 5.69 only). I will check out 
your change and see what remains.
  
  > Also can you check your commit messages, I don't know if it's phab being 
weird, but they all start with "t/" in the phab UI,
  
  Sorry about that. I had all of the patches in `topgit`, but when I wanted to 
submit them `arc` didn't work (only on this particular repository, and the 
problem was something with curl ... I don't know). So I tried `git-phab` and it 
didn't give me chance to edit stuff like `arc`.
  
  I noticed KDE is moving from phabricator to gitlab. To me at least, that 
sounds like **great news**!

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D29811

To: jpalecek, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29811: t/simplify-sending-data-through-socket

[David Edmundson]

davidedmundson added a comment.


  Your base kcrash is quite out of date - I simplified this method considerably 
a month ago, which gets rid of the two paths.
  
  Also can you check your commit messages, I don't know if it's phab being 
weird, but they all start with "t/" in the phab UI,

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D29811

To: jpalecek, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29811: t/simplify-sending-data-through-socket

[Jiří Paleček]

jpalecek edited the summary of this revision.
jpalecek added a reviewer: Frameworks.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D29811

To: jpalecek, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29811: t/simplify-sending-data-through-socket

[Jiří Paleček]

jpalecek added a dependent revision: D29812: t/handle-errors-from-socket.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D29811

To: jpalecek
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29811: t/simplify-sending-data-through-socket

[Jiří Paleček]

jpalecek created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jpalecek requested review of this revision.

REVISION SUMMARY
  Simplify sending data through socket, avoid using one large buffer
  
  Depends on D29810 
  Signed-off-by: Jiří Paleček 

REPOSITORY
  R285 KCrash

BRANCH
  for-upstream

REVISION DETAIL
  https://phabricator.kde.org/D29811

AFFECTED FILES
  src/kcrash.cpp

To: jpalecek
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns