D29832: Fix Endianness issue during wallet decryption

[Chris Coetzee]

chriscz added a comment.


  Hi @ngraham Thanks for letting me know! I've opened the PR over on gitlab: 
https://invent.kde.org/frameworks/kwallet/-/merge_requests/1. It must be quite 
a mission getting everyone over to new platforms  

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D29832

To: chriscz, dfaure, aacid
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29832: Fix Endianness issue during wallet decryption

[Nathaniel Graham]

ngraham added a reviewer: aacid.
ngraham added a comment.


  Thanks for the patch! FWIW we have moved patch review to GitLab; consider 
abandoning this and re-submitting it as a merge request at 
https://invent.kde.org/frameworks/kwallet/-/merge_requests
  
  Here's some documentation: https://community.kde.org/Infrastructure/GitLab

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D29832

To: chriscz, dfaure, aacid
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29832: Fix Endianness issue during wallet decryption

[Chris Coetzee]

chriscz added a comment.


  This stack overflow answer  has a more 
exhaustive approach to determining endianness. It may be worth extracting this 
code into a more appropriate header file though. Also here's the issue on the 
bugzilla tracker 

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D29832

To: chriscz, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29832: Fix Endianness issue during wallet decryption

[Chris Coetzee]

chriscz created this revision.
chriscz added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chriscz requested review of this revision.

REVISION SUMMARY
  Correctly determine endianness on the specific platform using `endian.h' 
header available at least on GCC. Must be verified for other platforms and 
compilers.

TEST PLAN
  make install; killall kwalletd5; kwalletd5; kwalletmanager5
  Open wallet, enter password. Wallet now accepts my password and I can still 
see my passwords.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D29832

AFFECTED FILES
  src/runtime/kwalletd/backend/blowfish.cc
  src/runtime/kwalletd/backend/sha1.cc

To: chriscz, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns