D4917: [Breeze Plasma Theme] Improve action-overlay icons

2017-03-07 Thread Kai Uwe Broulik 
broulik added a comment.


  > only a draft based on the old design with the new semantic.
  
  The graphic is missing some states (add-hover, add-pressed, open-normal, 
open-hovered, remove-hover, remove-pressed). Not a fan of having a blue remove 
icon. Also, I was told the arrow isn't a particular good icon for the idea of 
opening the folder in a popup, maybe there's a better icon for it.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4917

To: broulik, #plasma, #vdg, andreask, alex-l, mart
Cc: andreaska, hein, plasma-devel, #frameworks, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D4917: [Breeze Plasma Theme] Improve action-overlay icons

2017-03-06 Thread Andreas Kainz 
andreaska added a comment.


  F2753390: action-overlays.svgz  only a 
draft (not finished, only that you can review something)
  F2753393: overlayScreenshot.png 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4917

To: broulik, #plasma, #vdg, andreask, alex-l, mart
Cc: andreaska, hein, plasma-devel, #frameworks, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D4917: [Breeze Plasma Theme] Improve action-overlay icons

2017-03-06 Thread Kai Uwe Broulik 
broulik added a comment.


  The icons are copied from the Breeze icon set. Granted, it's an "emblem" icon 
and not one from "actions" which is arguably wrong but I wanted to be 
consistent with Dolphin here… also, I expressed my frustration with our current 
visual design workflow numerous times, so I won't put anymore effort than that 
into it. (I already wasted too much time in Inkscape (and a text editor) on 
this)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4917

To: broulik, #plasma, #vdg, andreask, alex-l, mart
Cc: hein, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D4917: [Breeze Plasma Theme] Improve action-overlay icons

2017-03-06 Thread Eike Hein 
hein added a comment.


  I wouldn't have veto'd it, but FWIW I think those icons don't work - their 
stem strength is much wider than Breeze lineart icons, they feel very out of 
place in our UX.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4917

To: broulik, #plasma, #vdg, andreask, alex-l, mart
Cc: hein, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D4917: [Breeze Plasma Theme] Improve action-overlay icons

2017-03-06 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:badf8acfe2c0: [Breeze Plasma Theme] Improve 
action-overlay icons (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4917?vs=12120=12239

REVISION DETAIL
  https://phabricator.kde.org/D4917

AFFECTED FILES
  src/desktoptheme/breeze/widgets/action-overlays.svgz

To: broulik, #plasma, #vdg, andreask, alex-l, mart
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D4917: [Breeze Plasma Theme] Improve action-overlay icons

2017-03-06 Thread Marco Martin 
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4917

To: broulik, #plasma, #vdg, andreask, alex-l, mart
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D4917: [Breeze Plasma Theme] Improve action-overlay icons

2017-03-06 Thread Kai Uwe Broulik 
broulik edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4917

To: broulik, #plasma, #vdg, andreask, alex-l
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D4917: [Breeze Plasma Theme] Improve action-overlay icons

2017-03-05 Thread Kai Uwe Broulik 
broulik added reviewers: andreask, alex-l.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4917

To: broulik, #plasma, #vdg, andreask, alex-l
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D4917: [Breeze Plasma Theme] Improve action-overlay icons

2017-03-03 Thread Kai Uwe Broulik 
broulik edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4917

To: broulik, #plasma, #vdg
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D4917: [Breeze Plasma Theme] Improve action-overlay icons

2017-03-03 Thread Kai Uwe Broulik 
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  The current ones aren't really descriptive and vastly different from what 
Dolphin uses.
  
  BUG: 376321

TEST PLAN
  Needs https://phabricator.kde.org/D4915 for hover/pressed state to work 
properly
  
  F2676409: Screenshot_20170303_140357.png 

  
  action-overlays.svgz for plasma-framework/src/desktoptheme/breeze/widgets
  F2676410: action-overlays.svgz 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4917

AFFECTED FILES
  src/desktoptheme/breeze/widgets/action-overlays.svgz

To: broulik, #plasma, #vdg
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol