D4924: [Containment Interface] Trigger context menus on pressing "Menu" key
broulik added a dependent revision: D4962: [Folder View] Open context menu when pressing Menu key. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4924 To: broulik, #plasma, #vdg, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D4924: [Containment Interface] Trigger context menus on pressing "Menu" key
This revision was automatically updated to reflect the committed changes. Closed by commit R242:94a6a168cf45: [Containment Interface] Trigger context menus on pressing "Menu" key (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4924?vs=12131=12243 REVISION DETAIL https://phabricator.kde.org/D4924 AFFECTED FILES src/scriptengines/qml/plasmoid/containmentinterface.cpp src/scriptengines/qml/plasmoid/containmentinterface.h To: broulik, #plasma, #vdg, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D4924: [Containment Interface] Trigger context menus on pressing "Menu" key
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4924 To: broulik, #plasma, #vdg, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D4924: [Containment Interface] Trigger context menus on pressing "Menu" key
broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY When pressing the "Menu" key, pretend a right-click happened and show the containment context menu. TEST PLAN FolderView eats the key event so far but on Desktop works. It works for both the regular context menu as well as if you have set it to show application launcher. It doesn't trigger the applet's context menu, however, but the only applets that can get focus are stuff like folder view and notes. Applets could still intercept it (in fact, FolderView has commented code that is supposed to do this, will have a look at this) and do their own thing. Only if the event isn't accepted it will propagate all the way to the containment and trigger the menu. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4924 AFFECTED FILES src/scriptengines/qml/plasmoid/containmentinterface.cpp src/scriptengines/qml/plasmoid/containmentinterface.h To: broulik, #plasma, #vdg Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol