D4932: Cookies KCM: disable "delete" button when there is no current item

2017-03-04 Thread David Faure
dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D4932

To: dfaure, lesliezhai
Cc: #frameworks


D4932: Cookies KCM: disable "delete" button when there is no current item

2017-03-04 Thread David Faure
dfaure added a comment.


  I'm curious to find out whether the clang static analyzer still complains or 
realizes this is fine now :)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4932

To: dfaure, lesliezhai
Cc: #frameworks


D4932: Cookies KCM: disable "delete" button when there is no current item

2017-03-04 Thread Leslie Zhai
lesliezhai accepted this revision.
lesliezhai added a comment.
This revision is now accepted and ready to land.


  Hi David,
  
  Looks good to me!
  
  Regards,
  Leslie Zhai

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4932

To: dfaure, lesliezhai
Cc: #frameworks


D4932: Cookies KCM: disable "delete" button when there is no current item

2017-03-04 Thread David Faure
dfaure created this revision.
Restricted Application added a project: Frameworks.

TEST PLAN
  kcmshell5 cookies

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4932

AFFECTED FILES
  src/kcms/kio/kcookiesmanagement.cpp

To: dfaure, lesliezhai
Cc: #frameworks