D5574: Don't set ItemHasContents in DropArea

2017-04-27 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:dec0d3d1c4f5: Don't set ItemHasContents in DropArea 
(authored by davidedmundson).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5574?vs=13767=13882

REVISION DETAIL
  https://phabricator.kde.org/D5574

AFFECTED FILES
  src/qmlcontrols/draganddrop/DeclarativeDropArea.cpp

To: davidedmundson, #plasma, aacid
Cc: plasma-devel, #frameworks, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5574: Don't set ItemHasContents in DropArea

2017-04-25 Thread Albert Astals Cid 
aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5574

To: davidedmundson, #plasma, aacid
Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D5574: Don't set ItemHasContents in DropArea

2017-04-24 Thread David Edmundson 
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  ItemHasContents means we get included in generating the QSG node
  treeview when we render.
  
  This item doesn't have any contents. It's like a MouseArea.
  
  ::setEnabled() doesn't need updating as it was already missing.

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5574

AFFECTED FILES
  src/qmlcontrols/draganddrop/DeclarativeDropArea.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol