D5623: fix build against Android NDK (API Level 21 is required)

2017-05-08 Thread Matthieu Gallien 
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:ecee5fc8e3cc: fix build against Android NDK (API Level 21 
is required) (authored by mgallien).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5623?vs=13901=14306

REVISION DETAIL
  https://phabricator.kde.org/D5623

AFFECTED FILES
  src/xattr_p.h

To: mgallien, #android, #frameworks, apol
Cc: apol, #frameworks

D5623: fix build against Android NDK (API Level 21 is required)

2017-05-08 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5623

To: mgallien, #android, #frameworks, apol
Cc: apol, #frameworks

D5623: fix build against Android NDK (API Level 21 is required)

2017-05-08 Thread Matthieu Gallien 
mgallien added a comment.


  Ping

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D5623

To: mgallien, #android, #frameworks
Cc: apol, #frameworks

D5623: fix build against Android NDK (API Level 21 is required)

2017-04-27 Thread Matthieu Gallien 
mgallien updated this revision to Diff 13901.
mgallien added a comment.


  added a comment and also modify the commit message

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5623?vs=13887=13901

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5623

AFFECTED FILES
  src/xattr_p.h

To: mgallien, #android, #frameworks
Cc: apol, #frameworks

D5623: fix build against Android NDK (API Level 21 is required)

2017-04-27 Thread Aleix Pol Gonzalez 
apol added a reviewer: Frameworks.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D5623

To: mgallien, #android, #frameworks
Cc: apol, #frameworks

D5623: fix build against Android NDK (API Level 21 is required)

2017-04-27 Thread Aleix Pol Gonzalez 
apol added a comment.


  +1 LGTM.
  
  Maybe you can specify on the commit message that `attr/xattr.h` isn't present 
on the Android NDK and add a comment on the ifdef wouldn't hurt either.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D5623

To: mgallien, #android
Cc: apol, #frameworks

D5623: fix build against Android NDK (API Level 21 is required)

2017-04-27 Thread Matthieu Gallien 
mgallien added a reviewer: Android.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D5623

To: mgallien, #android
Cc: #frameworks

D5623: fix build against Android NDK (API Level 21 is required)

2017-04-27 Thread Matthieu Gallien 
mgallien created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  fix build against Android NDK (API Level 21 is required)

TEST PLAN
  Test compilation under linux and Android

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5623

AFFECTED FILES
  src/xattr_p.h

To: mgallien
Cc: #frameworks