D5725: Workaround for MSVC and catalog loading

2017-05-06 Thread Luigi Toscano 
This revision was automatically updated to reflect the committed changes.
Closed by commit R238:b308f0cdb338: Workaround for MSVC and catalog loading 
(authored by ltoscano).

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5725?vs=14182=14198

REVISION DETAIL
  https://phabricator.kde.org/D5725

AFFECTED FILES
  CMakeLists.txt
  src/xslt.cpp

To: ltoscano, bcooksley
Cc: bcooksley, #frameworks, #documentation, skadinna

D5725: Workaround for MSVC and catalog loading

2017-05-06 Thread Ben Cooksley 
bcooksley accepted this revision.
bcooksley added a comment.
This revision is now accepted and ready to land.


  Code looks fine from my perspective, let's confirm this fixes things.

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5725

To: ltoscano, bcooksley
Cc: bcooksley, #frameworks, #documentation, skadinna

D5725: Workaround for MSVC and catalog loading

2017-05-05 Thread Ben Cooksley 
bcooksley added a comment.


  Unfortunately our Jenkins Jobs aren't configured to apply patches, so there 
isn't a way of testing this as such other than through:
  
  1. Some manual handling
  2. Committing it and seeing what happens.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D5725

To: ltoscano
Cc: bcooksley, #frameworks, #documentation, skadinna

D5725: Workaround for MSVC and catalog loading

2017-05-05 Thread Luigi Toscano 
ltoscano added a subscriber: bcooksley.
ltoscano added a comment.


  @bcooksley , is there a way to test this properly in the new CI (aka: without 
me manually applying some patches), to see if I didn't do something weird that 
made it work by accident?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D5725

To: ltoscano
Cc: bcooksley, #frameworks, #documentation, skadinna

D5725: Workaround for MSVC and catalog loading

2017-05-05 Thread Luigi Toscano 
ltoscano updated this revision to Diff 14182.
ltoscano added a comment.


  Readd docs

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5725?vs=14181=14182

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5725

AFFECTED FILES
  CMakeLists.txt
  src/xslt.cpp

To: ltoscano
Cc: #frameworks, #documentation, skadinna

D5725: Workaround for MSVC and catalog loading

2017-05-05 Thread Luigi Toscano 
ltoscano created this revision.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added subscribers: Documentation, Frameworks.

REVISION SUMMARY
  Apparently setting XML_CATALOG_FILES has no effects on Windows
  at least with MSVC (2017). The variable seems to be set, so
  there may be an issue with the linking, or in libxml2, or
  in some other unidentified place. Forcibly setting the
  catalog seems to work, but let's leave it as a special case
  on MSVC only for now.

TEST PLAN
  Tested on the new CI, tested a package with documentation
  (kconfigwidgets)

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5725

AFFECTED FILES
  src/xslt.cpp

To: ltoscano
Cc: #frameworks, #documentation, skadinna