D6041: Port a bunch of classes away from Plasma::Package
This revision was automatically updated to reflect the committed changes. Closed by commit R242:563011436d5f: Port a bunch of classes away from Plasma::Package (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6041?vs=15015=15220 REVISION DETAIL https://phabricator.kde.org/D6041 AFFECTED FILES autotests/CMakeLists.txt autotests/packageurlinterceptortest.cpp autotests/packageurlinterceptortest.h src/plasma/package.cpp src/plasma/package.h src/plasma/pluginloader.cpp src/plasma/pluginloader.h src/plasmaquick/appletquickitem.cpp src/plasmaquick/appletquickitem.h src/plasmaquick/configview.cpp src/plasmaquick/containmentview.cpp src/plasmaquick/packageurlinterceptor.cpp src/plasmaquick/packageurlinterceptor.h src/plasmaquick/private/appletquickitem_p.h src/plasmaquick/view.cpp src/scriptengines/qml/plasmoid/containmentinterface.cpp src/scriptengines/qml/plasmoid/wallpaperinterface.cpp src/scriptengines/qml/plasmoid/wallpaperinterface.h To: apol, #frameworks, #plasma, mart Cc: davidedmundson, mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6041: Port a bunch of classes away from Plasma::Package
apol added a comment. Yes sure. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6041 To: apol, #frameworks, #plasma, mart Cc: davidedmundson, mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6041: Port a bunch of classes away from Plasma::Package
davidedmundson added a comment. Can we wait till after the next release is tagged as that's super soon and this isn't that important. We've had major bugs porting stuff in this area before. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6041 To: apol, #frameworks, #plasma, mart Cc: davidedmundson, mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6041: Port a bunch of classes away from Plasma::Package
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6041 To: apol, #frameworks, #plasma, mart Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6041: Port a bunch of classes away from Plasma::Package
apol updated this revision to Diff 15015. apol marked an inline comment as done. apol added a comment. Address Marco's comments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6041?vs=15003=15015 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6041 AFFECTED FILES autotests/CMakeLists.txt autotests/packageurlinterceptortest.cpp autotests/packageurlinterceptortest.h src/plasma/package.cpp src/plasma/package.h src/plasma/pluginloader.cpp src/plasma/pluginloader.h src/plasmaquick/appletquickitem.cpp src/plasmaquick/appletquickitem.h src/plasmaquick/configview.cpp src/plasmaquick/containmentview.cpp src/plasmaquick/packageurlinterceptor.cpp src/plasmaquick/packageurlinterceptor.h src/plasmaquick/private/appletquickitem_p.h src/plasmaquick/view.cpp src/scriptengines/qml/plasmoid/containmentinterface.cpp src/scriptengines/qml/plasmoid/wallpaperinterface.cpp src/scriptengines/qml/plasmoid/wallpaperinterface.h To: apol, #frameworks, #plasma, mart Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6041: Port a bunch of classes away from Plasma::Package
apol marked 2 inline comments as done. apol added inline comments. INLINE COMMENTS > mart wrote in appletquickitem.h:105 > despite the warning in the header, this ended up being an exported symbol, so > binary compatibility rules apply here too. > Plasma::Package appletPackage() const; has to stay, eventually deprecated and > a new KPackage::Package appletPackage() const; added. Okay, will fix in a next patch. Please note nobody is using these methods and we could possibly scrap altogether the storing of appletPackage and coronaPackage. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6041 To: apol, #frameworks, #plasma, mart Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6041: Port a bunch of classes away from Plasma::Package
mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > pluginloader.h:208 > + **/ > +PLASMA_DEPRECATED KPluginInfo::List listAppletInfoForMimeType(const > QString ); > + wow, phab isn't that smart in the diff it makes checking for binary compatibility quite tricky ;) > appletquickitem.h:105 > > -Plasma::Package appletPackage() const; > -void setAppletPackage(const Plasma::Package ); > +KPackage::Package appletPackage() const; > +void setAppletPackage(const KPackage::Package ); despite the warning in the header, this ended up being an exported symbol, so binary compatibility rules apply here too. Plasma::Package appletPackage() const; has to stay, eventually deprecated and a new KPackage::Package appletPackage() const; added. > wallpaperinterface.h:26 > > -#include > +#include > +#include why plasma_export.h? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6041 To: apol, #frameworks, #plasma, mart Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6041: Port a bunch of classes away from Plasma::Package
apol created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Ported away some classes, removes many unneeded casts that happen when starting. TEST PLAN Tests still pass, plasma starts properly REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6041 AFFECTED FILES autotests/CMakeLists.txt autotests/packageurlinterceptortest.cpp autotests/packageurlinterceptortest.h src/plasma/pluginloader.cpp src/plasma/pluginloader.h src/plasmaquick/appletquickitem.cpp src/plasmaquick/appletquickitem.h src/plasmaquick/configview.cpp src/plasmaquick/containmentview.cpp src/plasmaquick/packageurlinterceptor.cpp src/plasmaquick/packageurlinterceptor.h src/plasmaquick/private/appletquickitem_p.h src/plasmaquick/view.cpp src/scriptengines/qml/plasmoid/containmentinterface.cpp src/scriptengines/qml/plasmoid/wallpaperinterface.cpp src/scriptengines/qml/plasmoid/wallpaperinterface.h To: apol, #frameworks, #plasma Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
