D6394: Add KF6-TODO to make KComboBox::minimumSizeHint() public

2017-06-27 Thread Friedrich W. H. Kossebau 
This revision was automatically updated to reflect the committed changes.
Closed by commit R284:1910d3ac9b1e: Add KF6-TODO to make 
KComboBox::minimumSizeHint() public (authored by kossebau).

REPOSITORY
  R284 KCompletion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6394?vs=15882=15902

REVISION DETAIL
  https://phabricator.kde.org/D6394

AFFECTED FILES
  src/kcombobox.h

To: kossebau, #frameworks, dfaure
Cc: cfeck, apol

D6394: Add KF6-TODO to make KComboBox::minimumSizeHint() public

2017-06-26 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R284 KCompletion

BRANCH
  addkf5todo

REVISION DETAIL
  https://phabricator.kde.org/D6394

To: kossebau, #frameworks, dfaure
Cc: cfeck, apol

D6394: Add KF6-TODO to make KComboBox::minimumSizeHint() public

2017-06-26 Thread Christoph Feck 
cfeck added a comment.


  +1
  
  That shouldn't have landed in "protected" area.
  
  And no, MSVC has not changed :)

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D6394

To: kossebau, #frameworks
Cc: cfeck, apol

D6394: Add KF6-TODO to make KComboBox::minimumSizeHint() public

2017-06-26 Thread Friedrich W. H. Kossebau 
kossebau added inline comments.

INLINE COMMENTS

> apol wrote in kcombobox.h:527
> Why KF6? changing visibility doesn't break ABI, AFAIK. We should just not 
> reorder them.

https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B 
hints the access rights are mangled into the symbol signature with some 
compilers. At least MSVC is mentioned here: 
http://blog.qt.io/blog/2009/08/12/some-thoughts-on-binary-compatibility/

Happy to learn that things have changed meanwhile, this is my latest info on 
that matter, never heard of anything else :)

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D6394

To: kossebau, #frameworks
Cc: apol

D6394: Add KF6-TODO to make KComboBox::minimumSizeHint() public

2017-06-26 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> kcombobox.h:527
>  
> +// TODO KF6: make public like in base classes, so consumers do not need 
> to cast to base classes
> +// when they have a KComboBox (or subclasses) object and want to access 
> this property

Why KF6? changing visibility doesn't break ABI, AFAIK. We should just not 
reorder them.

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D6394

To: kossebau, #frameworks
Cc: apol

D6394: Add KF6-TODO to make KComboBox::minimumSizeHint() public

2017-06-26 Thread Friedrich W. H. Kossebau 
kossebau created this revision.
Restricted Application added a project: Frameworks.

REPOSITORY
  R284 KCompletion

BRANCH
  addkf5todo

REVISION DETAIL
  https://phabricator.kde.org/D6394

AFFECTED FILES
  src/kcombobox.h

To: kossebau, #frameworks