D6867: Add PowerShell highlighting

2017-07-24 Thread Volker Krause 
vkrause closed this revision.
vkrause added a comment.


  Pushed to master.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D6867

To: vkrause, dhaumann, vonreth
Cc: #frameworks

D6867: Add PowerShell highlighting

2017-07-24 Thread Dominik Haumann 
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks good to me.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D6867

To: vkrause, dhaumann, vonreth
Cc: #frameworks

D6867: Add PowerShell highlighting

2017-07-24 Thread Volker Krause 
vkrause updated this revision to Diff 17103.
vkrause added a comment.


  Right, license is due to the original file.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6867?vs=17094=17103

REVISION DETAIL
  https://phabricator.kde.org/D6867

AFFECTED FILES
  autotests/folding/craftenv.ps1.fold
  autotests/html/craftenv.ps1.html
  autotests/input/craftenv.ps1
  autotests/reference/craftenv.ps1.ref
  data/syntax/powershell.xml

To: vkrause, dhaumann, vonreth
Cc: #frameworks

D6867: Add PowerShell highlighting

2017-07-24 Thread Dominik Haumann 
dhaumann added a comment.


  Ah, and we need spellChecking="0" almost everywhere except for HereString and 
String, and comments right?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D6867

To: vkrause, dhaumann, vonreth
Cc: #frameworks

D6867: Add PowerShell highlighting

2017-07-24 Thread Dominik Haumann 
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.


  Looks almost good, but I think another iteration would be nice.
  
  I assume we cannot relicense to MIT?

INLINE COMMENTS

> powershell.xml:5
> +  version="1"
> +  kateversion="3.4"
> +  extensions="*.ps1;*.ps1m;*.ps1d"

If I remember correctly, the default style dsBuiltIn was added with the first 
release of KDE Frameworks 5, see all bold entries here:
https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/

So kateversion="5.0" is required here.

> powershell.xml:918
> +  
> +  
> +  

Since we require kateversion 5.0 anyways, we could also use dsVerbatimString 
instead of dsString.

> powershell.xml:922
> +  
> +   selColor="#ff" bold="0" italic="0" spellChecking="false" />
> +   color="#FF" selColor="#ff" bold="1" italic="0" spellChecking="false" 
> />

Suggestion: use dsVariable for variables, and remove all hardcoded colors and 
bold and italic.

> powershell.xml:923
> +   selColor="#ff" bold="0" italic="0" spellChecking="false" />
> +   color="#FF" selColor="#ff" bold="1" italic="0" spellChecking="false" 
> />
> +

dsConstant would be better.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D6867

To: vkrause, dhaumann, vonreth
Cc: #frameworks

D6867: Add PowerShell highlighting

2017-07-24 Thread Volker Krause 
vkrause created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Based on https://github.com/jgm/highlighting-kate/pull/80/ with some fixes 
and improvements.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D6867

AFFECTED FILES
  autotests/folding/craftenv.ps1.fold
  autotests/html/craftenv.ps1.html
  autotests/input/craftenv.ps1
  autotests/reference/craftenv.ps1.ref
  data/syntax/powershell.xml

To: vkrause, dhaumann, vonreth
Cc: #frameworks