D6895: Handle fine-grained wheel event in zoomin

2017-08-06 Thread Allan Sandfeld Jensen
carewolf closed this revision.
carewolf added a comment.


  Already landed

REVISION DETAIL
  https://phabricator.kde.org/D6895

To: carewolf, cullmann
Cc: #frameworks


D6895: Handle fine-grained wheel event in zoomin

2017-07-25 Thread Allan Sandfeld Jensen
carewolf added a comment.


  DefaultDeltasPerStep is always exactly 120 :D

REVISION DETAIL
  https://phabricator.kde.org/D6895

To: carewolf, cullmann
Cc: #frameworks


D6895: Handle fine-grained wheel event in zoomin

2017-07-25 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Looks reasonable to me.
  I assume the DefaultDeltasPerStep is always > 0 ;=)

REVISION DETAIL
  https://phabricator.kde.org/D6895

To: carewolf, cullmann
Cc: #frameworks


D6895: Handle fine-grained wheel event in zoomin

2017-07-25 Thread Allan Sandfeld Jensen
carewolf updated this revision to Diff 17169.
carewolf added a comment.


  Fix smoothness of zooming down

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6895?vs=17167=17169

REVISION DETAIL
  https://phabricator.kde.org/D6895

AFFECTED FILES
  src/render/katerenderer.cpp
  src/render/katerenderer.h
  src/view/kateviewinternal.cpp
  src/view/kateviewinternal.h

To: carewolf, cullmann
Cc: #frameworks


D6895: Handle fine-grained wheel event in zoomin

2017-07-25 Thread Allan Sandfeld Jensen
carewolf added a reviewer: cullmann.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D6895

To: carewolf, cullmann
Cc: #frameworks


D6895: Handle fine-grained wheel event in zoomin

2017-07-25 Thread Allan Sandfeld Jensen
carewolf created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Avoid zooming in or out too fast when wheel events are finer grained.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D6895

AFFECTED FILES
  src/render/katerenderer.cpp
  src/render/katerenderer.h
  src/view/kateviewinternal.cpp
  src/view/kateviewinternal.h

To: carewolf
Cc: #frameworks