D7142: Fix proxy KCM not loading manual proxies correctly.

2017-08-07 Thread David Faure 
dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7142

To: dfaure, dmariano, davidedmundson
Cc: #frameworks

D7142: Fix proxy KCM not loading manual proxies correctly.

2017-08-04 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7142

To: dfaure, dmariano, davidedmundson
Cc: #frameworks

D7142: Fix proxy KCM not loading manual proxies correctly.

2017-08-04 Thread David Faure 
dfaure created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  commit 
https://phabricator.kde.org/R241:4e2a52c67167507b62553ca595bb561b925dc440 
prepends a scheme (like socks://), which interfers with
  the assumption that after the first ':' comes the port.
  But we can use QUrl parsing to extract the port number, instead.

TEST PLAN
  kcmshell5 proxy, setting manual proxy values, OK, kcmshell5 proxy

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7142

AFFECTED FILES
  src/kcms/kio/kproxydlg.cpp

To: dfaure, dmariano
Cc: #frameworks