D7281: KCoreAddons: Enforce hidden symbol visibility in nested private classes

2017-08-15 Thread Ben Cooksley 
bcooksley added a comment.


  I'm not sure why that happened - it automatically associated correctly so it 
should have closed.
  
  It does appear that one of the reviews 
(https://phabricator.kde.org/tag/frameworks/) hasn't approved it yet so that 
may be the reason why.
  (Phabricator upstream are big on stuff not going in without proper review)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D7281

To: mpyne, #frameworks, kossebau
Cc: bcooksley, kossebau

D7281: KCoreAddons: Enforce hidden symbol visibility in nested private classes

2017-08-14 Thread Friedrich W . H . Kossebau 
kossebau closed this revision.
kossebau added a comment.


  Hm, I tried to close this one by adding a line
  Differential Revision: https://phabricator.kde.org/D7281 
  in the commit, but seems that was not picked up, so closing manually
  See eb5f8570f4aa3f6391ef0c040f55b1331e36e0c7

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D7281

To: mpyne, #frameworks, kossebau
Cc: kossebau

D7281: KCoreAddons: Enforce hidden symbol visibility in nested private classes

2017-08-14 Thread Friedrich W . H . Kossebau 
kossebau accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D7281

To: mpyne, #frameworks, kossebau
Cc: kossebau

D7281: KCoreAddons: Enforce hidden symbol visibility in nested private classes

2017-08-13 Thread Michael Pyne 
mpyne added a comment.


  In https://phabricator.kde.org/D7281#135053, @kossebau wrote:
  
  > @mpyne: Beware, I have such patches prepared for all of KF :)
  
  
  OK, I'll hold off on this one pending your KF5-wide patchset ;)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D7281

To: mpyne, #frameworks
Cc: kossebau

D7281: KCoreAddons: Enforce hidden symbol visibility in nested private classes

2017-08-13 Thread Friedrich W . H . Kossebau 
kossebau added a comment.


  @mpyne: Beware, I have such patches prepared for all of KF :)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D7281

To: mpyne, #frameworks
Cc: kossebau

D7281: KCoreAddons: Enforce hidden symbol visibility in nested private classes

2017-08-12 Thread Michael Pyne 
mpyne created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Inspired by https://phabricator.kde.org/D7279, manually declare nested 
Private classes to have hidden visibility (by default, they inherit the 
visibility of the class that they are nested under).
  
  This removes the private symbols from the resulting .so (I've verified this 
myself) although it's only a micro-optimization with regard to binary size.

TEST PLAN
  All autotests continue to pass, no additional build warnings.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D7281

AFFECTED FILES
  src/lib/caching/kshareddatacache.cpp
  src/lib/caching/kshareddatacache_win.cpp
  src/lib/jobs/kjobtrackerinterface.cpp
  src/lib/jobs/kjobuidelegate.cpp
  src/lib/kaboutdata.cpp
  src/lib/randomness/krandomsequence.cpp
  src/lib/util/kdelibs4configmigrator.cpp
  src/lib/util/kuser_unix.cpp
  src/lib/util/kuser_win.cpp

To: mpyne, #frameworks