D7368: [KACLEditWidget] Allow double clicking to edit entry
This revision was automatically updated to reflect the committed changes. Closed by commit R241:1d480054428d: [KACLEditWidget] Allow double clicking to edit entry (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7368?vs=18292=18654#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7368?vs=18292=18654 REVISION DETAIL https://phabricator.kde.org/D7368 AFFECTED FILES src/widgets/kacleditwidget.cpp src/widgets/kacleditwidget_p.h To: broulik, dfaure Cc: #frameworks
D7368: [KACLEditWidget] Allow double clicking to edit entry
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> kacleditwidget.cpp:951
> +
> +// avoid conflict with clicking to toggle premission
> +if (column >= 2 && column <= 4) {
typo: permission
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7368
To: broulik, dfaure
Cc: #frameworks
D7368: [KACLEditWidget] Allow double clicking to edit entry
broulik added a comment. Ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7368 To: broulik, dfaure Cc: #frameworks
D7368: [KACLEditWidget] Allow double clicking to edit entry
broulik created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This is less cumbersome than having to select an item and then clicking "Edit Entry" TEST PLAN - Verified that double-clicking one of the built-in ones (Owner, Group, Mask) does not yield the dialog - Verified that double-clicking one of the check marks does not yield the dialog to avoid conflicting interaction REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7368 AFFECTED FILES src/widgets/kacleditwidget.cpp src/widgets/kacleditwidget_p.h To: broulik, dfaure Cc: #frameworks
