D7402: Use QUrls from match to create mimeData in base implementation

2017-08-21 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R308:b0421c21867b: Use QUrls from match to create mimeData in 
base implementation (authored by davidedmundson).

REPOSITORY
  R308 KRunner

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7402?vs=18368=18482

REVISION DETAIL
  https://phabricator.kde.org/D7402

AFFECTED FILES
  src/abstractrunner.cpp

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7402: Use QUrls from match to create mimeData in base implementation

2017-08-19 Thread Kai Uwe Broulik 
broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> abstractrunner.cpp:204
>  {
> -Q_UNUSED(match)
> -return nullptr;
> +if (match.urls().isEmpty()) {
> +return nullptr;

Weird indentation

REPOSITORY
  R308 KRunner

BRANCH
  dbusrunner

REVISION DETAIL
  https://phabricator.kde.org/D7402

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7402: Use QUrls from match to create mimeData in base implementation

2017-08-18 Thread David Edmundson 
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  QueryMatch contains a list of URLs.
  
  If an AbstractRunner doesn't implement this method, create some mimeData
  from the availalbe data in the base implementation.

TEST PLAN
  Have a DBus runner which populates a bunch of URLs, but doesn't implement 
this method.

REPOSITORY
  R308 KRunner

BRANCH
  dbusrunner

REVISION DETAIL
  https://phabricator.kde.org/D7402

AFFECTED FILES
  src/abstractrunner.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas