D7697: emit dirty signal for a directory on creation of a file even if the file is being watched individually

2017-09-05 Thread Julian Wolff 
progwolff abandoned this revision.
progwolff added a comment.


  Invalid. Worked as expected without my changes. I did not test it correctly.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D7697

To: progwolff, #frameworks

D7697: emit dirty signal for a directory on creation of a file even if the file is being watched individually

2017-09-05 Thread Julian Wolff 
progwolff edited the summary of this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D7697

To: progwolff, #frameworks

D7697: emit dirty signal for a directory on creation of a file even if the file is being watched individually

2017-09-05 Thread Julian Wolff 
progwolff created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  KDirWatch emits a dirty signal for a watched directory when a file is ceated 
in this directory.
  However, currently this signal is not emitted when a file is added that is 
watched individually.
  With this patch, a dirty signal for the directory is sent even if a watched 
file is added.
  
  This fixes a bug in Okular.
  
  BUG: 384185
  
  See also the discussion in https://phabricator.kde.org/D7671

TEST PLAN
  Watched a directory and a file in this directory.
  Deleted and recreated the file.
  
  1. a "deleted" signal for the file is emitted
  2. a "dirty" signal for the directory is emitted
  3. a "created" signal for the file is emitted
  4. a "dirty" signal for the directory is emitted
  
  Tested only with inotify. There may be other places for other backends which 
need changes.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7697

AFFECTED FILES
  src/lib/io/kdirwatch.cpp

To: progwolff, #frameworks