D7828: fix createKMessageBox focus widget inconsistency

2017-11-02 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:19a313ecc90c: fix createKMessageBox focus widget 
inconsistency (authored by emateli, committed by ngraham).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7828?vs=21453=21820

REVISION DETAIL
  https://phabricator.kde.org/D7828

AFFECTED FILES
  src/kmessagebox.cpp

To: emateli, #frameworks, ngraham, aacid, #vdg, rkflx, subdiff
Cc: elvisangelaccio, rkflx, abetts, subdiff, ngraham, aacid, #frameworks

D7828: fix createKMessageBox focus widget inconsistency

2017-11-02 Thread Nathaniel Graham 
ngraham added a comment.


  I think we've got enough thumbs up. I'm gonna land this.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D7828

To: emateli, #frameworks, ngraham, aacid, #vdg, rkflx, subdiff
Cc: elvisangelaccio, rkflx, abetts, subdiff, ngraham, aacid, #frameworks

D7828: fix createKMessageBox focus widget inconsistency

2017-11-02 Thread Roman Gilg 
subdiff accepted this revision.
subdiff added a comment.


  Looked at the code and I think @rkflx explained the situation quite well (if 
we should force passing a parent or not - better - for the QDialogButtonBox).

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D7828

To: emateli, #frameworks, ngraham, aacid, #vdg, rkflx, subdiff
Cc: elvisangelaccio, rkflx, abetts, subdiff, ngraham, aacid, #frameworks

D7828: fix createKMessageBox focus widget inconsistency

2017-11-02 Thread Emirald Mateli 
emateli added a comment.


  Ping @subdiff @abetts does this iteration work for you guys? It's marked as 
ready to land but I feel that we should get an overall opinion on this.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D7828

To: emateli, #frameworks, ngraham, aacid, #vdg, rkflx
Cc: elvisangelaccio, rkflx, abetts, subdiff, ngraham, aacid, #frameworks

D7828: fix createKMessageBox focus widget inconsistency

2017-10-30 Thread Nathaniel Graham 
ngraham added a comment.


  Thanks @aacid. Any remaining objections to landing this?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D7828

To: emateli, #frameworks, ngraham, aacid, #vdg, rkflx
Cc: elvisangelaccio, rkflx, abetts, subdiff, ngraham, aacid, #frameworks

D7828: fix createKMessageBox focus widget inconsistency

2017-10-30 Thread Nathaniel Graham 
ngraham set the repository for this revision to R236 KWidgetsAddons.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D7828

To: emateli, #frameworks, ngraham, aacid, #vdg, rkflx
Cc: elvisangelaccio, rkflx, abetts, subdiff, ngraham, aacid, #frameworks

D7828: fix createKMessageBox focus widget inconsistency

2017-10-30 Thread Albert Astals Cid 
aacid resigned from this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  This change is much less invasive than before, i'm not giving a +1 since i 
don't immediately understand why this fixes things and since i don't have time 
to investigate it, i'm removing my -1

REVISION DETAIL
  https://phabricator.kde.org/D7828

To: emateli, #frameworks, ngraham, aacid, #vdg, rkflx
Cc: elvisangelaccio, rkflx, abetts, subdiff, ngraham, aacid, #frameworks

D7828: fix createKMessageBox focus widget inconsistency

2017-10-30 Thread Emirald Mateli 
emateli retitled this revision from "fix createKMessageBox focus button 
inconsistency" to "fix createKMessageBox focus widget inconsistency".

REVISION DETAIL
  https://phabricator.kde.org/D7828

To: emateli, #frameworks, ngraham, aacid, #vdg, rkflx
Cc: elvisangelaccio, rkflx, abetts, subdiff, ngraham, aacid, #frameworks