D7898: Only send OutputConfig sendApplied / sendFailed to the right resource
This revision was automatically updated to reflect the committed changes. Closed by commit R127:2b3f9509ac12: Only send OutputConfig sendApplied / sendFailed to the right resource (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7898?vs=19711=19738 REVISION DETAIL https://phabricator.kde.org/D7898 AFFECTED FILES src/server/outputconfiguration_interface.cpp To: davidedmundson, #plasma, sebas Cc: sebas, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, apol, mart, hein
D7898: Only send OutputConfig sendApplied / sendFailed to the right resource
sebas added a comment. FWIW, I tested it, it fixes kwin crashing when adding a setApplied() call on the OutputConfiguration, and it also means the applied signal arrives. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D7898 To: davidedmundson, #plasma, sebas Cc: sebas, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, apol, mart, hein
D7898: Only send OutputConfig sendApplied / sendFailed to the right resource
sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. Yes, the initial idea was to send applied() to all connected resources. That is not s_allResources, so your patch is correct. The resources that are actually bound are not currently tracked. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D7898 To: davidedmundson, #plasma, sebas Cc: sebas, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, apol, mart, hein
D7898: Only send OutputConfig sendApplied / sendFailed to the right resource
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY I don't understand the original logic. s_allResources contains /every/ resource, not just outputconfigurations. Sending org_kde_kwin_outputconfiguration_send_applied to a wl_surface (for example), results in an error. The reason kwin doesn't currently crash is because we don't actually send applied/failed after setting outputs. (which is another bug) TEST PLAN The existing unit test still passes. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D7898 AFFECTED FILES src/server/outputconfiguration_interface.cpp To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
