D8256: Add _XOPEN_SOURCE to C definitions

[Michael Pyne]

mpyne added a comment.


  Sorry, if I'd been able to check this earlier I'd have warned against 
pushing, this was the kind of concern I was addressing with my earlier comment 
about FreeBSD. I had run into a lot of those issues when trying to get KF5 to 
build on Alpine.
  
  Adding an _XOPEN_SOURCE or similar define will in general require a lot of 
porting effort to remove things like obsolete type names, BSD-specific 
extensions, functions used in later standards than the one we adopt, etc.
  
  It was easier for me to make fixes per-Framework than to try to get 
everything to compile under an _XOPEN_SOURCE setting, but it may be better as a 
long-term concern to standardize on something and then do the one-time cost to 
make sure everything still builds. Certainly I think we don't want to continue 
to rely implicitly on glibc forever given the expansion of other form factors 
that use alternate libc's.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8256

To: awilcox, alexmerry, dfaure
Cc: bcooksley, #freebsd, kde-frameworks-devel, kde-buildsystem, mpyne, dfaure, 
michaelh, ngraham, bruns

D8256: Add _XOPEN_SOURCE to C definitions

[David Faure]

dfaure added a comment.


  Indeed,
  
  22:23:51 In file included from /usr/include/sys/mount.h:36:
  22:23:51 /usr/include/sys/ucred.h:84:2: error: unknown type name 'u_int'; did 
you mean 'uint'?
  22:23:51 u_int   cr_version; /* structure layout version 
*/
  22:23:51 ^
  
  
https://build.kde.org/view/Frameworks/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.11/5/console
  
  I'll revert.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8256

To: awilcox, alexmerry, dfaure
Cc: bcooksley, #freebsd, kde-frameworks-devel, kde-buildsystem, mpyne, dfaure, 
michaelh, ngraham, bruns

D8256: Add _XOPEN_SOURCE to C definitions

[Ben Cooksley]

bcooksley added subscribers: FreeBSD, bcooksley.
bcooksley added a comment.


  This change appears to have resulted in a severe regression of builds on 
FreeBSD.
  Any ideas?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8256

To: awilcox, alexmerry, dfaure
Cc: bcooksley, #freebsd, kde-frameworks-devel, kde-buildsystem, mpyne, dfaure, 
michaelh, ngraham, bruns

D8256: Add _XOPEN_SOURCE to C definitions

[David Faure]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:6684cb99bdf4: Add _XOPEN_SOURCE to C definitions 
(authored by awilcox, committed by dfaure).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8256?vs=20623&id=40740

REVISION DETAIL
  https://phabricator.kde.org/D8256

AFFECTED FILES
  kde-modules/KDECompilerSettings.cmake

To: awilcox, alexmerry, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, mpyne, dfaure, michaelh, ngraham, 
bruns

D8256: Add _XOPEN_SOURCE to C definitions

[David Faure]

dfaure added a comment.


  Ah, found it in bugzilla :-)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8256

To: awilcox, alexmerry, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, mpyne, dfaure, michaelh, ngraham, 
bruns

D8256: Add _XOPEN_SOURCE to C definitions

[David Faure]

dfaure added a comment.


  Let's push this then ;)
  
  You don't seem to have a developer account? I can push this but I need your 
email address for the git authorship.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8256

To: awilcox, alexmerry, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, mpyne, dfaure, michaelh, ngraham, 
bruns

D8256: Add _XOPEN_SOURCE to C definitions

[A. Wilcox]

awilcox added a comment.


  rindex was being used in kscreenlocker but that code was removed last year.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8256

To: awilcox, alexmerry, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, mpyne, dfaure, michaelh, ngraham, 
bruns

D8256: Add _XOPEN_SOURCE to C definitions

[David Faure]

dfaure added a comment.
Restricted Application edited subscribers, added: kde-buildsystem, 
kde-frameworks-devel; removed: Frameworks, Build System.


  (BTW where is rindex being used? lxr says only in ksysguard's FreeBSD and 
IRIX files, surely that's not the issue?)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8256

To: awilcox, alexmerry, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, mpyne, dfaure, michaelh, ngraham, 
bruns, #frameworks, #build_system

D8256: Add _XOPEN_SOURCE to C definitions

[Michael Pyne]

mpyne added a comment.


  As I mentioned on the KDE bug, there is a possibility that changes like this 
would break FreeBSD.  FreeBSD operates by a model of exporting symbols by 
default for legacy/BSD-specific needs.  However if a feature flag is set, it 
limits its exports to *only* that required by the feature flag.  Notably, all 
BSD-specific exports are removed in FreeBSD if you set a feature flag that 
doesn't also standardize that BSD feature, and unlike C libraries like musl and 
glibc, they don't support any feature flags to specifically request 
BSD-specific exports be exported.
  
  See KIO commit 15451d505fdbc37b5d027f8ad1ba6aeb6314cc2d 

 and https://phabricator.kde.org/D6597 for an example of where I had to take 
special pains when committing musl-specific fixes to KF5 to avoid breaking 
FreeBSD.
  
  Andrew, have you been able to test your patches on a FreeBSD at all?  We can 
catch it in CI now, but on the other hand I have already tried to fix this by 
pushing feature flag defines into source repositories requiring the extra 
defines rather than making it a KDE-wide define.  I had previously verified 
that these fixes allowed all of KF5 (though not all of Plasma5) to build on 
Alpine Linux, though it's been a month since I had reverified that.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8256

To: awilcox, alexmerry, dfaure
Cc: mpyne, dfaure, #frameworks, #build_system

D8256: Add _XOPEN_SOURCE to C definitions

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  I did a test compile with this locally and it seems fine indeed.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8256

To: awilcox, alexmerry, dfaure
Cc: dfaure, #frameworks, #build_system

D8256: Add _XOPEN_SOURCE to C definitions

[A . Wilcox]

awilcox added a comment.


  Please do note that `_XOPEN_SOURCE` must be `600` and not `700` because some 
components of KDE still use `rindex` which is no longer supported in X/Open 7 
.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8256

To: awilcox, alexmerry
Cc: #frameworks, #build_system

D8256: Add _XOPEN_SOURCE to C definitions

[A . Wilcox]

awilcox created this revision.
awilcox added a reviewer: alexmerry.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.

REVISION SUMMARY
  (This was reported on the KDE bug tracker as Bug 373175 
.  The summary of that bug 
follows.)
  
  When building on non-glibc Unix platforms, such as Solaris, NetBSD, and 
Linux/musl or Linux/uclibc, multiple components of KF5 fail to build.  This is 
because -std=iso9899:1990 is specified (for strict C90 compliance) but 
_XOPEN_SOURCE is not defined, so none of the POSIX interfaces are exported.  I 
have seen this reported in at least:
  
  - kinit
  - kscreenlocker
  - plasma-workspace
  
  The attached patch resolves this issue on all our build boxes; additionally, 
applying it to my glibc builder did not change the already working result.

TEST PLAN
  The entire Adélie Linux distribution's set of KDE packages has been built 
against extra-cmake-modules-5.38.0 with this patch applied.  The Plasma 5 
desktop and KDE software build, test, and run correctly (where applicable).

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8256

AFFECTED FILES
  kde-modules/KDECompilerSettings.cmake

To: awilcox, alexmerry
Cc: #frameworks, #build_system