D8461: Remove unused config.h.cmake entries

2017-11-10 Thread David Kahles 
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:d636fdc569ea: Remove unused config.h.cmake entries 
(authored by davidk).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8461?vs=22171&id=22172

REVISION DETAIL
  https://phabricator.kde.org/D8461

AFFECTED FILES
  ConfigureChecks.cmake
  config.h.cmake

To: davidk, dfaure
Cc: dfaure, #frameworks

D8461: Remove unused config.h.cmake entries

2017-11-10 Thread David Kahles 
davidk updated this revision to Diff 22171.
davidk added a comment.


  Improve commit message

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8461?vs=21277&id=22171

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D8461

AFFECTED FILES
  ConfigureChecks.cmake
  config.h.cmake

To: davidk, dfaure
Cc: dfaure, #frameworks

D8461: Remove unused config.h.cmake entries

2017-11-09 Thread David Kahles 
davidk added a comment.


  Thanks for the git hint and the revew.
  Then we should remove this code too.

REPOSITORY
  R293 Baloo

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D8461

To: davidk, dfaure
Cc: dfaure, #frameworks

D8461: Remove unused config.h.cmake entries

2017-11-05 Thread David Faure 
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  The answer to "I'm not sure why" is easy: `git log -S MALLOC` shows exactly 
two commits, the one that introduced the usage of this stuff, and the one that 
removed it again. Ain't git great?
  
  BTW, I see more dead code, like `baloo_removexattr`, `baloo_getxattr` and 
then apparently baloo_setxattr is only used by unittests.

REPOSITORY
  R293 Baloo

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D8461

To: davidk, dfaure
Cc: dfaure, #frameworks

D8461: Remove unused config.h.cmake entries

2017-10-24 Thread David Kahles 
davidk updated this revision to Diff 21277.
davidk added a comment.


  Fix commit message.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8461?vs=21276&id=21277

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D8461

AFFECTED FILES
  ConfigureChecks.cmake
  config.h.cmake

To: davidk
Cc: #frameworks

D8461: Remove unused config.h.cmake entries

2017-10-24 Thread David Kahles 
davidk created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  I'm not sure why they were introduced, but they aren't used anywhere in the
  code.

TEST PLAN
  - "grep -r HAVE_MALLOC_H baloo"
  - "grep -r HAVE_MALLOC_TRIM baloo"
- Compiles.

REPOSITORY
  R293 Baloo

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D8461

AFFECTED FILES
  ConfigureChecks.cmake
  config.h.cmake

To: davidk
Cc: #frameworks