D9077: Bug 377342 Question

[Christoph Cullmann]

cullmann abandoned this revision.
cullmann added a comment.


  Abandoned in favor of https://phabricator.kde.org/D9175

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9077

To: cullmann, christofg
Cc: loh.tar, kwrite-devel, kde-frameworks-devel, cullmann, hase, michaelh, 
ngraham, bruns, demsking, head7, kfunk, sars, dhaumann

D9077: Bug 377342 Question

[Christoph Cullmann]

cullmann commandeered this revision.
cullmann added a reviewer: christofg.
cullmann added a comment.


  :( Sorry that this never got attention.
  
  We have already
  
  https://phabricator.kde.org/D9175
  
  for this, that includes this change and more, but was never finalized.
  If somebody can pick that other thing up, might be most useful, I will close 
this one.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9077

To: cullmann, christofg
Cc: loh.tar, kwrite-devel, kde-frameworks-devel, cullmann, hase, michaelh, 
ngraham, bruns, demsking, head7, kfunk, sars, dhaumann

D9077: Bug 377342 Question

[loh tar]

loh.tar added subscribers: cullmann, loh.tar.
loh.tar added a comment.
Herald edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: 
Frameworks.


  @cullmann I thing you could give a short hint
  
  But perhaps is @christofg no longer interested to work on this issue

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9077

To: christofg
Cc: loh.tar, kwrite-devel, kde-frameworks-devel, cullmann, hase, michaelh, 
ngraham, bruns, demsking, head7, kfunk, sars, dhaumann, #frameworks

D9077: Bug 377342 Question

[Christof Groschke]

christofg created this revision.
christofg added a project: KTextEditor.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  I have a little question related to migrating from QRegExp to 
QRegularExpression in ktexteditor. I first changed only on occurrence for now, 
pls see the attached diff. I hope this works as a quick solution to the problem 
but I'm not sure here.
  
  I would like to change every occurrence in ktexteditor. Todo that I need to 
change KateRegExp. By doing that I would touch a lot more of the code.
  
  My question now is, what's the best way to get started here ... Change one 
occurrence at a time, or do them all at once ...
  
  I appreciate the help :)
  
  Related Bug 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9077

AFFECTED FILES
  src/search/kateplaintextsearch.cpp
  src/search/kateplaintextsearch.h

To: christofg
Cc: #frameworks, kevinapavew, ngraham, demsking, head7, cullmann, kfunk, sars, 
dhaumann