D9217: KUriFilter: don't return an error on non-existing files.
This revision was automatically updated to reflect the committed changes. Closed by commit R241:f3bb9edbf5b3: KUriFilter: dont return an error on non-existing files. (authored by dfaure). Restricted Application added a project: Frameworks. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9217?vs=23539=24056 REVISION DETAIL https://phabricator.kde.org/D9217 AFFECTED FILES autotests/kurifiltertest.cpp src/urifilters/shorturi/kshorturifilter.cpp To: dfaure, emateli, elvisangelaccio, gregormi, dhaumann Cc: dhaumann, broulik, #frameworks
D9217: KUriFilter: don't return an error on non-existing files.
dhaumann added a comment. @dfaure Better push today than one day before release. ;) BRANCH master REVISION DETAIL https://phabricator.kde.org/D9217 To: dfaure, emateli, elvisangelaccio, gregormi, dhaumann Cc: dhaumann, broulik, #frameworks
D9217: KUriFilter: don't return an error on non-existing files.
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. From my side this looks good. A second OK is always better, but I'd be OK if you go ahead. Thanks for the ping! BRANCH master REVISION DETAIL https://phabricator.kde.org/D9217 To: dfaure, emateli, elvisangelaccio, gregormi, dhaumann Cc: dhaumann, broulik, #frameworks
D9217: KUriFilter: don't return an error on non-existing files.
dfaure added a comment. What you mention about the file dialog happens with any non-existing dir, so it's unrelated to this patch. I agree that it should be improved somehow, in the file dialog, hopefully not with a messagebox but something more builtin. Anyhow, can I get this one approved, if we all agree on it? REVISION DETAIL https://phabricator.kde.org/D9217 To: dfaure, emateli, elvisangelaccio, gregormi Cc: dhaumann, broulik, #frameworks
D9217: KUriFilter: don't return an error on non-existing files.
dhaumann added a comment. I was just testing this. With this patch, a non-existing ~/test: 1. Dolphin goes to /home/dh/test, and a red box tells the folder does not exist. This is better than the protocol-error message, so https://bugs.kde.org/show_bug.cgi?id=372813 should be fixed. 2. In the file open-dialog: This expands also to /home/dh/test, but does not raise an error. So the contents of the listview remains the same. In summary: 1. is certainly better with this patch. 2. file open dialog was possibly better without this patch, since "~/home" resulted in "/" and not silently in some location that does not exist. This should probably be improved in the file-open dialog itself? All in all, this patch is an improvement. REVISION DETAIL https://phabricator.kde.org/D9217 To: dfaure, emateli, elvisangelaccio, gregormi Cc: dhaumann, broulik, #frameworks
D9217: KUriFilter: don't return an error on non-existing files.
dhaumann added a reviewer: gregormi. REVISION DETAIL https://phabricator.kde.org/D9217 To: dfaure, emateli, elvisangelaccio, gregormi Cc: broulik, #frameworks
D9217: KUriFilter: don't return an error on non-existing files.
emateli added a comment. I can't seem to be able to properly run this(whatever changes I make to the kshorturifilter.cpp seem to be ignored?!) but on paper looks good to me. Do we mark https://phabricator.kde.org/D8920 as abandoned, or wait for this to commit then the new `dir` property of KUrlNavigator can be pushed as well. REVISION DETAIL https://phabricator.kde.org/D9217 To: dfaure, emateli, elvisangelaccio Cc: broulik, #frameworks
D9217: KUriFilter: don't return an error on non-existing files.
broulik added a comment. https://bugs.kde.org/show_bug.cgi?id=372813 REVISION DETAIL https://phabricator.kde.org/D9217 To: dfaure, emateli, elvisangelaccio Cc: broulik, #frameworks
D9217: KUriFilter: don't return an error on non-existing files.
dfaure added a comment. That's exactly what this fixes (not only ~/foo but also /foo/bar). Out of curiosity, in which context (app) were you seeing that issue? REVISION DETAIL https://phabricator.kde.org/D9217 To: dfaure, emateli, elvisangelaccio Cc: broulik, #frameworks
D9217: KUriFilter: don't return an error on non-existing files.
broulik added a comment. Will this fix typing `~/foo` when foo does not exist return an invalid URL? REVISION DETAIL https://phabricator.kde.org/D9217 To: dfaure, emateli, elvisangelaccio Cc: broulik, #frameworks
D9217: KUriFilter: don't return an error on non-existing files.
dfaure created this revision. dfaure added reviewers: emateli, elvisangelaccio. REVISION SUMMARY This allows to use partially-typed paths for completion purposes. TEST PLAN Adjusted unittest passes. BRANCH master REVISION DETAIL https://phabricator.kde.org/D9217 AFFECTED FILES autotests/kurifiltertest.cpp src/urifilters/shorturi/kshorturifilter.cpp To: dfaure, emateli, elvisangelaccio Cc: #frameworks
